Make ProofBatch async to avoid blocking the ledger utility process #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Feb 28, 2019
| } | ||
|
|
||
| void BatContribution::ProofBatchCallback( | ||
| const braveledger_bat_helper::BathProofs& batch_proof, |
There was a problem hiding this comment.
I know it was like this before, but with s sounds better
There was a problem hiding this comment.
fixed with ec256f8, also fix BatchProofs typo
NejcZdovc
previously approved these changes
Feb 28, 2019
NejcZdovc
approved these changes
Feb 28, 2019
yrliou
added a commit
that referenced
this pull request
Feb 28, 2019
Make ProofBatch async to avoid blocking the ledger utility process
yrliou
added a commit
that referenced
this pull request
Feb 28, 2019
Make ProofBatch async to avoid blocking the ledger utility process
This was referenced Feb 28, 2019
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
…_dist Add build_omaha option to create_dist command
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
…_dist Add build_omaha option to create_dist command
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
…_dist Add build_omaha option to create_dist command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#3393
Just for reference, back when ledger was still running on the browser process, we had brave-intl/bat-native-ledger#148 to avoid blocking the UI thread.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#3393 (comment)
Reviewer Checklist: