Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure task scheduler is already initialized in ledger lib #3571

Closed
yrliou opened this issue Mar 4, 2019 · 1 comment · Fixed by brave/brave-core#1835
Closed

Ensure task scheduler is already initialized in ledger lib #3571

yrliou opened this issue Mar 4, 2019 · 1 comment · Fixed by brave/brave-core#1835

Comments

@yrliou
Copy link
Member

yrliou commented Mar 4, 2019

brave/brave-core#1800 added a task runner in ledger lib.
Task scheduler used in the ledger lib is already initialized by chromium code in desktop case but not in iOS.
We would need to ensure task scheduler is initialized before creating the task runner in ledger lib to avoid crashes on iOS.

@btlechowski
Copy link

btlechowski commented Mar 20, 2019

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#1835

Verification passed on

Brave 0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment