Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4283: Disabling field trials #4551

Merged
merged 2 commits into from
May 29, 2019
Merged

Issue 4283: Disabling field trials #4551

merged 2 commits into from
May 29, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented May 23, 2019 •
edited
Loading

Fix #4283

PR builder passed: https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-4551/24/

Description

This PR disables field trials in Brave by setting fieldtrial_testing_like_official_build in config.js.

The follow-up PR: brave/brave-core#2471 :

  1. Adds test for disabling field trials
  2. Resets security indicator to display locks instead of security chips for EV certs (to match the behavior in current release builds)
  3. Removes features that were disabled in brave_main_delegate.cc to override field trials

Submitter Checklist:

Test Plan:

  1. Navigate to brave://version and verify that only one variation is enabled
Variations | HideShortcutsOnNtp:HideShortcutsExperiment

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde force-pushed the disable_field_trials branch from b70e246 to 55ec4dc Compare May 23, 2019 15:31
@jumde jumde mentioned this pull request May 23, 2019
Closed
@diracdeltas diracdeltas mentioned this pull request May 23, 2019
Merged
28 tasks
diracdeltas
diracdeltas reviewed May 23, 2019
View reviewed changes
package.json Outdated
@@ -42,7 +42,7 @@
},
"brave-core": {
"dir": "src/brave",
"branch": "master",
"branch": "disable_field_trials",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be reverted once PR builder goes through

diracdeltas
diracdeltas reviewed May 23, 2019
View reviewed changes
lib/config.js
@@ -64,6 +64,7 @@ Config.prototype.buildArgs = function () {
const chrome_version_parts = this.chromeVersion.split('.')

let args = {
fieldtrial_testing_like_official_build: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jumde jumde force-pushed the disable_field_trials branch 4 times, most recently from b66abde to c07d69a Compare May 24, 2019 15:18
@jumde jumde self-assigned this May 24, 2019
bridiver
bridiver previously approved these changes May 24, 2019
View reviewed changes
@jumde jumde force-pushed the disable_field_trials branch from c07d69a to 1e5c27b Compare May 24, 2019 20:26
@jumde jumde added the CI/Skip label May 25, 2019
@bridiver bridiver mentioned this pull request May 28, 2019
Merged
19 tasks
darkdh added a commit to brave/brave-core that referenced this pull request May 28, 2019
@darkdh
Remove manually disable field trail feature
2cb26c9 
Make sure brave/brave-browser#4551 and
#2471 landed first
@jumde jumde merged commit 69bc205 into master May 29, 2019
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone May 29, 2019
darkdh added a commit to brave/brave-core that referenced this pull request May 30, 2019
@darkdh
Remove manually disable field trail feature
0c6b9b4 
Make sure brave/brave-browser#4551 and
#2471 landed first
@bsclifton bsclifton mentioned this pull request May 30, 2019
Open
darkdh added a commit to brave/brave-core that referenced this pull request May 30, 2019
@darkdh
Remove manually disable field trail feature
19333c7 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request May 31, 2019
@darkdh
Remove manually disable field trail feature
26b1d96 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Jun 18, 2019
@darkdh
Remove manually disable field trail feature
e8e3417 
Make sure brave/brave-browser#4551 and
#2471 landed first
@bsclifton bsclifton deleted the disable_field_trials branch June 24, 2019 06:58
@bsclifton bsclifton mentioned this pull request Jun 24, 2019
Closed
darkdh added a commit to brave/brave-core that referenced this pull request Jul 16, 2019
@darkdh
Remove manually disable field trail feature
7413857 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Jul 18, 2019
@darkdh
Remove manually disable field trail feature
0758c67 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Jul 23, 2019
@darkdh
Remove manually disable field trail feature
c193e25 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Aug 9, 2019
@darkdh
Remove manually disable field trail feature
d251beb 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Aug 9, 2019
@darkdh
Remove manually disable field trail feature
ddb80a5 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Aug 15, 2019
@darkdh
Remove manually disable field trail feature
e182e55 
Make sure brave/brave-browser#4551 and
#2471 landed first
darkdh added a commit to brave/brave-core that referenced this pull request Aug 19, 2019
@darkdh
Remove manually disable field trail feature
c5fbe1f 
Make sure brave/brave-browser#4551 and
#2471 landed first
@diracdeltas diracdeltas mentioned this pull request Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas left review comments

@bridiver bridiver bridiver approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

@bbondy bbondy Awaiting requested review from bbondy

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging this pull request may close these issues.

Disable field trials
4 participants
@jumde @bridiver @diracdeltas @bsclifton