Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Upgrade typescript-eslint-parser to 17.0.1 #169

Merged
merged 3 commits into from
Nov 17, 2018
Merged

Upgrade typescript-eslint-parser to 17.0.1 #169

merged 3 commits into from
Nov 17, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 17, 2018 •
edited
Loading

typescript 2.9
typescript-eslint-parser: 17.0.1

solve #137

macklinu
macklinu approved these changes Nov 17, 2018
View reviewed changes
Copy link
Collaborator

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

macklinu
macklinu reviewed Nov 17, 2018
View reviewed changes
package.json Outdated
"typescript": "~2.8.1",
"typescript-eslint-parser": "^15.0.0"
"typescript": "~2.9",
"typescript-eslint-parser": "^16.0.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this out locally to see how far we could increase the version of typescript + the parser before more tests started breaking, and it looks like we can upgrade to the following safely from this commit.

"typescript": "~3.0.3",
"typescript-eslint-parser": "^19.0.2"

Should we do that in this PR or a follow up? /cc @bradzacher

j-f1
j-f1 approved these changes Nov 17, 2018
View reviewed changes
Copy link
Collaborator

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM either way.

@armano2
Copy link
Contributor Author

armano2 commented Nov 17, 2018 •
edited
Loading

@macklinu @j-f1 should i go forward with upgrading or wait for this to be merged?

@armano2
Copy link
Contributor Author

armano2 commented Nov 17, 2018 •
edited
Loading

typescript-eslint-parser v20 has some breaking changes, i will prepare fix for them

but should i do this conditionally

if typescript-eslint-parser < 20 than
......
else
....

or just add it to peerDependencies?

@armano2 armano2 changed the title Upgrade typescript-eslint-parser to 16.0.1 Upgrade typescript-eslint-parser to 17.0.1 Nov 17, 2018
@bradzacher
Copy link
Owner

thanks @armano2!

feel free to branch off your branch so you can continue working whilst you wait for us to catch up.

in regards to the v20 compatibility.
we'll be releasing these changes as a breaking change to v1.0.0, so don't worry about backwards compatibility.

@bradzacher bradzacher merged commit f6041a6 into bradzacher:master Nov 17, 2018
@armano2
Copy link
Contributor Author

armano2 commented Nov 17, 2018

ok :>

@armano2 armano2 deleted the typescript-eslint-parser-16 branch November 19, 2018 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macklinu macklinu macklinu approved these changes

@bradzacher bradzacher bradzacher approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armano2 @bradzacher @macklinu @j-f1