[DEPS] Upgrade typescript-eslint-parser to 17.0.1 (#169)

* Upgrade typescript-eslint-parser to 16.0.1 * Add test case * typescript-eslint-parser 17.0.1 Add addition tests for eslint/typescript-eslint-parser#491
bradzacher · Nov 17, 2018 · f6041a6 · f6041a6
1 parent 1090947
commit f6041a6
Show file tree

Hide file tree

Showing 6 changed files with 56 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -14,3 +14,4 @@ versions.json
 /packages/**/node_modules
 /.vscode
 .sublimelinterrc
+yarn.lock
diff --git a/lib/rules/no-type-alias.js b/lib/rules/no-type-alias.js
@@ -91,7 +91,12 @@ module.exports = {
             "in-intersections",
             "in-unions-and-intersections"
         ];
-        const aliasTypes = ["TSLastTypeNode", "TSArrayType", "TSTypeReference"];
+        const aliasTypes = [
+            "TSLastTypeNode",
+            "TSArrayType",
+            "TSTypeReference",
+            "TSLiteralType"
+        ];
 
         //----------------------------------------------------------------------
         // Helpers

diff --git a/package.json b/package.json
@@ -34,8 +34,8 @@
     "lint-staged": "^6.0.0",
     "mocha": "^4.0.1",
     "prettier": "^1.11.1",
-    "typescript": "~2.8.1",
-    "typescript-eslint-parser": "^15.0.0"
+    "typescript": "~2.9",
+    "typescript-eslint-parser": "^17.0.1"
   },
   "lint-staged": {
     "*.js": [

diff --git a/tests/lib/rules/explicit-member-accessibility.js b/tests/lib/rules/explicit-member-accessibility.js
@@ -30,6 +30,16 @@ class Test {
   public getX () {
     return this.x
   }
+}
+            `
+        },
+        {
+            filename: "test.ts",
+            code: `
+class Test {
+  protected name: string
+  protected foo?: string
+  public "foo-bar"?: string
 }
             `
         },
@@ -82,6 +92,31 @@ class Test {
                     column: 3
                 }
             ]
+        },
+        {
+            filename: "test.ts",
+            code: `
+class Test {
+  x?: number
+  getX? () {
+    return this.x
+  }
+}
+            `,
+            errors: [
+                {
+                    message:
+                        "Missing accessibility modifier on class property x.",
+                    line: 3,
+                    column: 3
+                },
+                {
+                    message:
+                        "Missing accessibility modifier on method definition getX.",
+                    line: 4,
+                    column: 3
+                }
+            ]
         }
     ]
 });
diff --git a/tests/lib/rules/member-ordering.js b/tests/lib/rules/member-ordering.js
@@ -161,6 +161,7 @@ interface Foo {
     D: string;
     E: string;
     F: string;
+    G?: string;
     J();
     K();
     L();

diff --git a/tests/lib/rules/no-type-alias.js b/tests/lib/rules/no-type-alias.js
@@ -496,6 +496,17 @@ type Foo<T> = {
 };
             `,
             options: [{ allowMappedTypes: "in-intersections" }]
+        },
+        {
+            code: `export type ClassValue = string | number | ClassDictionary | ClassArray | undefined | null | false;`,
+            options: [
+                {
+                    allowAliases: "in-unions-and-intersections",
+                    allowCallbacks: true,
+                    allowLiterals: "in-unions-and-intersections",
+                    allowMappedTypes: "in-unions-and-intersections"
+                }
+            ]
         }
     ],
     invalid: [