Allow tooltip via context #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helpful styling for tooltip content
smbea
commented
Jul 20, 2023
| <Tooltip value={ tooltip } labelId={ prefixId(id) }> | ||
| <Tooltip value={ tooltip } forId={ id } element={ props.element }> |
There was a problem hiding this comment.
Changed labelId to forId to serve a more general purpose, trigger element doesn't need to be a label
bpmn-io-tasks
bot
added
needs review
bpmn-io-tasks
bot
added
in progress
smbea
force-pushed
the
261-tooltip-via-context
branch
from
3e9f698 to
c1cad32
Compare
bpmn-io-tasks
bot
added
needs review
smbea
requested review from
a team,
philippfromme,
marstamm and
barmac
and removed request for
a team
smbea
force-pushed
the
261-tooltip-via-context
branch
from
c1cad32 to
c4978b3
Compare
smbea
force-pushed
the
261-tooltip-via-context
branch
from
c4978b3 to
2d13ae3
Compare
src/PropertiesPanel.js
Outdated
| * | ||
| * @typedef { { | ||
| * [id: String]: GetTooltipFunction | ||
| * } } TooltipConfig |
There was a problem hiding this comment.
Suggested change
| * } } TooltipConfig | |
| * } } TooltipConfig |
smbea
force-pushed
the
261-tooltip-via-context
branch
from
2d13ae3 to
6289a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261
Test against this branch: Existing descriptions provided by context were changed to tooltips provided by context.
The actual tooltip content and where they appear will be tackled later