Support tooltips in group headers #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
smbea
force-pushed
the
tooltip-in-group-headers
branch
from
7fb70dc to
93efa86
Compare
bpmn-io-tasks
bot
added
needs review
smbea
commented
Jul 21, 2023
| @@ -107,7 +107,9 @@ function Tooltip(props) { | |||
| onMouseEnter={ showTooltip } | |||
| onMouseLeave={ ()=> clearTimeout(timeout) } | |||
| onFocus={ showTooltip } | |||
| onKeyDown={ hideTooltipViaEscape }> | |||
| onKeyDown={ hideTooltipViaEscape } | |||
| onMouseDown={ (e)=> {e.preventDefault();} } | |||
There was a problem hiding this comment.
prevents tooltip from staying open after opening to click group
There was a problem hiding this comment.
Doesn't seem to work for me.
smbea
requested review from
a team,
philippfromme and
barmac
and removed request for
a team
bpmn-io-tasks
bot
added
in progress
smbea
force-pushed
the
tooltip-in-group-headers
branch
from
d66e943 to
93efa86
Compare
bpmn-io-tasks
bot
added
needs review
|
Let's go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test against this
bpmn-js-properties-panelbranch