Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(editor): move disabled entry to a toggle switch #641

Merged
merged 1 commit into from
May 15, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented May 3, 2023

Closes #639

image

image

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 3, 2023
@github-actions github-actions bot temporarily deployed to demo-639-disabled-toggle-switc May 3, 2023 11:23 Destroyed
@pinussilvestrus pinussilvestrus marked this pull request as ready for review May 3, 2023 11:29
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 3, 2023
@github-actions github-actions bot temporarily deployed to demo-639-disabled-toggle-switc May 3, 2023 11:29 Destroyed
@RomanKostka
Copy link

RomanKostka commented May 3, 2023

@pinussilvestrus
should we directly move the toggle to the right?
same here:

image

@pinussilvestrus
Copy link
Contributor Author

The toggle switch component of the properties panel renders it top-bottom as you can configure a switcherLabel to describe the state of the toggle (e.g. on/off).

image

We could

  • change this behavior in form-js as we anyway don't display such a switcher label
  • change it in the properties panel library to display it inline once no switcher label is declared => this would need extra effort outside of this PR, but would solve it for all toggle switches

Wdyt?

Copy link
Contributor

@vsgoulart vsgoulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it looks ok and couldn't find any problems while testing.
It just occurred to me that it might be better to use cursor: pointer for the toggle, I just don't know how easy it is to achieve that on from form-js side

@pinussilvestrus
Copy link
Contributor Author

If we anyway would need to override the styles to display the toggle inline (cf. #641 (comment)), then we could also add the pointer.

Depends on whether we see these things a form-js exclusive or worth adding to the properties panel core /cc @christian-konrad @RomanKostka

@pinussilvestrus pinussilvestrus force-pushed the 639-disabled-toggle-switch branch from e2aaf9b to ca39340 Compare May 9, 2023 13:30
@github-actions github-actions bot temporarily deployed to demo-639-disabled-toggle-switc May 9, 2023 13:30 Destroyed
@RomanKostka
Copy link

If we anyway would need to override the styles to display the toggle inline (cf. #641 (comment)), then we could also add the pointer.

Depends on whether we see these things a form-js exclusive or worth adding to the properties panel core

@pinussilvestrus @christian-konrad @YanaSegal from my point of view this is worth it adding to the property panel.

@pinussilvestrus pinussilvestrus merged commit cefe9e5 into develop May 15, 2023
@pinussilvestrus pinussilvestrus deleted the 639-disabled-toggle-switch branch May 15, 2023 08:27
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 15, 2023
@pinussilvestrus
Copy link
Contributor Author

Handling the styling improvements as part of bpmn-io/properties-panel#245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move disabled to a toggle switch
3 participants