-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(editor): move disabled
entry to a toggle switch
#641
Conversation
@pinussilvestrus |
The toggle switch component of the properties panel renders it top-bottom as you can configure a We could
Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise it looks ok and couldn't find any problems while testing.
It just occurred to me that it might be better to use cursor: pointer
for the toggle, I just don't know how easy it is to achieve that on from form-js
side
If we anyway would need to override the styles to display the toggle inline (cf. #641 (comment)), then we could also add the pointer. Depends on whether we see these things a form-js exclusive or worth adding to the properties panel core /cc @christian-konrad @RomanKostka |
e2aaf9b
to
ca39340
Compare
@pinussilvestrus @christian-konrad @YanaSegal from my point of view this is worth it adding to the property panel. |
Handling the styling improvements as part of bpmn-io/properties-panel#245. |
Closes #639