Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move disabled to a toggle switch #639

Closed
Tracked by #587
pinussilvestrus opened this issue May 3, 2023 · 0 comments · Fixed by #641
Closed
Tracked by #587

Move disabled to a toggle switch #639

pinussilvestrus opened this issue May 3, 2023 · 0 comments · Fixed by #641
Assignees
@pinussilvestrus
Labels
editor

Comments

@pinussilvestrus
Copy link
Contributor

What should we do?

With #636 we aim to add the readonly property as a toggle switch. We should do the same for disabled, to be consistent.

Why should we do it?

We think a toggle switch adds more value for these two properties than a simple checkbox. A toggle usually has an immediate effect on the UI, which is the case.
@pinussilvestrus pinussilvestrus mentioned this issue May 3, 2023
Closed
17 tasks
@pinussilvestrus pinussilvestrus self-assigned this May 3, 2023
pinussilvestrus pushed a commit that referenced this issue May 3, 2023
chore(editor): move disabled entry to a toggle switch
e2aaf9b 
Closes #639
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 3, 2023
@pinussilvestrus pinussilvestrus mentioned this issue May 3, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 3, 2023
pinussilvestrus pushed a commit that referenced this issue May 9, 2023
chore(editor): move disabled entry to a toggle switch
ca39340 
Closes #639
pinussilvestrus pushed a commit that referenced this issue May 15, 2023
chore(editor): move disabled entry to a toggle switch
cefe9e5 
Closes #639
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(editor): move disabled entry to a toggle switch bpmn-io/form-js
1 participant
@pinussilvestrus