-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize fix for swallowed hover events #503
Conversation
29c58d4
to
eee7816
Compare
When we create a solution for an upstream issue, the fix does not solve the issue yet. It will be the update of the dependency which solves the problem and the fix can only be Related to bpmn-io/bpmn-js#1366. For example, have a look at camunda/camunda-modeler#1997 |
I've tested this on my machine and it works correctly when the new module is included in |
I have made the HoverFixModule a dependency of the DraggingModule, so that anything that imports it initializes the hover fix in the process. This should implicitly enable it everywhere, so long as the dragging module is used. |
Additionally, the tests should now also ensure that the element-level hover fix doesn't need the dragging module bootstrapped to work, and that the dragging-level hover fix doesn't need the hover fix module bootstrapped to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing and we got it, I believe!
Replaces the old drag hover fix (which fixed kindof the same thing) with one that works in a general fashion only on element.* level. Related to bpmn-io/bpmn-js#1366
🆒 |
Replaces the old drag hover fix with one that works in a general fashion only on element.* level.
Related to bpmn-io/bpmn-js#1366
Acceptance Criteria
Definition of Done