Remove hover class of hovered element on drop

[azeghers]

Related to bpmn-io/bpmn-js#1366

Acceptance Criteria

• Corresponds to the concept
• Corresponds to the design

Definition of Done

• corresponds to the design principles
• corresponds to the code standards
• passes Continuous Integration checks
• available as feature branch on GitHub
  • contains the cleaned up commit history
  • commit messages satisfy our commit message guidelines
  • a single commit closes the issue via Closes #issuenr

[azeghers]

@nikku Let me know if this is the right direction and I'll write tests for it 😄

[nikku]

Please go ahead and write tests regardless of the actual implementation. Test should test the scenario at hand, using our APIs. They are often times more important than the actual implementation (where stuff is fixed and how), as they serve as the spec for the thing fixed.

[nikku]

Will have a look later today.

[nikku]

I thought the issue was:

Generally element.hover { A } -> element.out {A} -> element.hover {B} is fired
Firefox sometimes swallows the element.out {A} so we end up with a sequence of element.hover { A } -> element.hover {B} .

My intuition is that we should detect that broken sequence and emit the missing element.out {A}. If that is possible, it would be my preferred option.

Your solution drops the hover class, good. But it still leaves other components hanging that may rely on the proper sequence of hover -> out -> hover events.

[nikku]

Closed in favor of #503.