Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation for minimal iam permissions #775

Merged
merged 1 commit into from
May 18, 2023

Conversation

mjsterckx
Copy link
Contributor

@mjsterckx mjsterckx commented Feb 27, 2023

Issue number:

Related: #417

Description of changes:

Added a bottlerocket/docs/permissions folder that stores one or more JSON files for each agent. The files contain the minimal IAM permissions needed to create and run the test/resource. Added a MINIMAL-PERMISSIONS.md file that maps each sample test file in bottlerocket/samples to the corresponding minimal IAM permissions.

The JSON files were generated by running the sample test files with a different assume_role per test/resource. These assume_roles had Administrator permissions, and using CloudTrail, it was possible to see which permissions were actually used by that role from the time of creation to the time of deletion.

Testing done:

N/A

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@mjsterckx mjsterckx force-pushed the minimal-permissions branch 2 times, most recently from 41a5579 to 856ce3f Compare February 27, 2023 21:23
@ecpullen
Copy link
Contributor

Looks good so far.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@stmcginnis stmcginnis merged commit b70c2b7 into bottlerocket-os:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants