Skip to content

Commit

Permalink
Merge pull request #775 from mjsterckx/minimal-permissions
Browse files Browse the repository at this point in the history
docs: added documentation for minimal iam permissions
  • Loading branch information
stmcginnis authored May 18, 2023
2 parents 4260eb9 + aadebd9 commit b70c2b7
Show file tree
Hide file tree
Showing 19 changed files with 919 additions and 0 deletions.
105 changes: 105 additions & 0 deletions bottlerocket/docs/permissions/MINIMAL-PERMISSIONS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
# Minimal IAM Permission Map

This doc maps each manifest in [samples](../../samples) to the minimal IAM permissions needed to create and run the test and resources.

The policies can be created using the [aws iam create-policy](https://awscli.amazonaws.com/v2/documentation/api/latest/reference/iam/create-policy.html) command and attached to a role using [aws iam attach-role-policy](https://awscli.amazonaws.com/v2/documentation/api/latest/reference/iam/attach-role-policy.html).

## Without iam:CreateRole Permission

These policies do not include the `iam:CreateRole` permission.

In order for the resources and tests to be created as desired, the ARN of an existing role should be provided instead.

- For ECS clusters, this can be accomplished by adding a field `iamInstanceProfileName` to the ECS cluster config, the value of which is the ARN of a role with at least these permissions: [ecs-iam-instance-profile.json](./ecs-iam-instance-profile.json).

- For EKS clusters, this can be accomplished by replacing the `clusterName`, `region`, and `version` fields with an `encodedConfig` field in the EKS cluster config.
This field's value should be a string representing a base64-encoded EKS cluster config, an example of which can be found [here](./eksctl-config.yaml).
This config should contain the ARNs of an existing service role and an existing node instance role with at least these permissions: [eks-service-role.json](./eks-service-role.json) and [eks-node-instance-role.json](./eks-node-instance-role.json).

### ECS Test

- ecs-test-agent: [ecs-test-agent.json](./ecs-test-agent.json)
- ecs-resource-agent: [ecs-resource-agent.json](./ecs-resource-agent-no-create-role.json)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-ecs-cluster.json)

### ECS Migration Test

- ecs-test-agent: [ecs-test-agent.json](./ecs-test-agent.json)
- migration-test-agent: [migration-test-agent.json](./migration-test-agent-ecs-cluster.json)
- ecs-resource-agent: [ecs-resource-agent.json](./ecs-resource-agent-no-create-role.json)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-ecs-cluster.json)

### ECS Workload Test

- ecs-workload-agent: [ecs-workload-agent.json](./ecs-workload-agent.json)
- ecs-resource-agent: [ecs-resource-agent.json](./ecs-resource-agent-no-create-role.json)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-ecs-cluster.json)

### Sonobuoy Test

- sonobuoy-test-agent: [sonobuoy-test-agent.json](./sonobuoy-test-agent.json)
- eks-resource-agent: [eks-resource-agent.json](./eks-resource-agent-no-create-role.json) (if cluster should be created)
[eks-resource-agent-existing-cluster.json](./eks-resource-agent-existing-cluster.json) (if cluster already exists)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-eks-cluster.json)

### Sonobuoy Migration Test

- sonobuoy-test-agent: [sonobuoy-test-agent.json](./sonobuoy-test-agent.json)
- migration-test-agent: [migration-test-agent.json](./migration-test-agent-eks-cluster.json)
- eks-resource-agent: [eks-resource-agent.json](./eks-resource-agent-no-create-role.json) (if cluster should be created)
[eks-resource-agent-existing-cluster.json](./eks-resource-agent-existing-cluster.json) (if cluster already exists)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-eks-cluster.json)

### K8S Workload Test

- k8s-workload-agent: [k8s-workload-agent.json](./k8s-workload-agent.json)
- eks-resource-agent: [eks-resource-agent.json](./eks-resource-agent-no-create-role.json) (if cluster should be created)
[eks-resource-agent-existing-cluster.json](./eks-resource-agent-existing-cluster.json) (if cluster already exists)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-eks-cluster.json)

## With iam:CreateRole Permission

Some of these policies include the `iam:CreateRole` permission.

_Note_: This is considered dangerous because there is no limit to the permissions and policies that can be assigned to the role created this way, so this new role could end up with `Administrator` privileges.

### ECS Test

- ecs-test-agent: [ecs-test-agent.json](./ecs-test-agent.json)
- ecs-resource-agent: [ecs-resource-agent.json](./ecs-resource-agent-create-role.json)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-ecs-cluster.json)

### ECS Migration Test

- ecs-test-agent: [ecs-test-agent.json](./ecs-test-agent.json)
- migration-test-agent: [migration-test-agent.json](./migration-test-agent-ecs-cluster.json)
- ecs-resource-agent: [ecs-resource-agent.json](./ecs-resource-agent-create-role.json)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-ecs-cluster.json)

### ECS Workload Test

- ecs-workload-agent: [ecs-workload-agent.json](./ecs-workload-agent.json)
- ecs-resource-agent: [ecs-resource-agent.json](./ecs-resource-agent-create-role.json)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-ecs-cluster.json)

### Sonobuoy Test

- sonobuoy-test-agent: [sonobuoy-test-agent.json](./sonobuoy-test-agent.json)
- eks-resource-agent: [eks-resource-agent.json](./eks-resource-agent-create-cluster.json) (if cluster should be created)
[eks-resource-agent-existing-cluster.json](./eks-resource-agent-existing-cluster.json) (if cluster already exists)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-eks-cluster.json)

### Sonobuoy Migration Test

- sonobuoy-test-agent: [sonobuoy-test-agent.json](./sonobuoy-test-agent.json)
- migration-test-agent: [migration-test-agent.json](./migration-test-agent-eks-cluster.json)
- eks-resource-agent: [eks-resource-agent.json](./eks-resource-agent-create-cluster.json) (if cluster should be created)
[eks-resource-agent-existing-cluster.json](./eks-resource-agent-existing-cluster.json) (if cluster already exists)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-eks-cluster.json)

### K8S Workload Test

- k8s-workload-agent: [k8s-workload-agent.json](./k8s-workload-agent.json)
- eks-resource-agent: [eks-resource-agent.json](./eks-resource-agent-create-cluster.json) (if cluster should be created)
[eks-resource-agent-existing-cluster.json](./eks-resource-agent-existing-cluster.json) (if cluster already exists)
- ec2-resource-agent: [ec2-resource-agent.json](./ec2-resource-agent-eks-cluster.json)
54 changes: 54 additions & 0 deletions bottlerocket/docs/permissions/ec2-resource-agent-ecs-cluster.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"ec2:CreateTags",
"ec2:DescribeInstanceStatus"
],
"Resource": "*"
},
{
"Effect": "Allow",
"Action": [
"ec2:RunInstances",
"ec2:TerminateInstances"
],
"Resource": "arn:aws:ec2:${Region}:${Account}:instance/${InstanceId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:network-interface/${NetworkInterfaceId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:security-group/${SecurityGroupId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:subnet/${SubnetId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:volume/${VolumeId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}::image/${ImageId}"
},
{
"Effect": "Allow",
"Action": [
"ecs:DeregisterContainerInstance",
"ecs:ListContainerInstances"
],
"Resource": "arn:aws:ecs:${Region}:${Account}:cluster/${ClusterName}"
}
]
}
46 changes: 46 additions & 0 deletions bottlerocket/docs/permissions/ec2-resource-agent-eks-cluster.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"ec2:CreateTags",
"ec2:DescribeInstanceStatus"
],
"Resource": "*"
},
{
"Effect": "Allow",
"Action": [
"ec2:RunInstances",
"ec2:TerminateInstances"
],
"Resource": "arn:aws:ec2:${Region}:${Account}:instance/${InstanceId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:network-interface/${NetworkInterfaceId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:security-group/${SecurityGroupId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:subnet/${SubnetId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}:${Account}:volume/${VolumeId}"
},
{
"Effect": "Allow",
"Action": "ec2:RunInstances",
"Resource": "arn:aws:ec2:${Region}::image/${ImageId}"
}
]
}
30 changes: 30 additions & 0 deletions bottlerocket/docs/permissions/ecs-iam-instance-profile.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"ecs:DiscoverPollEndpoint",
"ssm:ListInstanceAssociations",
"ssm:UpdateInstanceInformation"
],
"Resource": "*"
},
{
"Effect": "Allow",
"Action": [
"ecr:BatchGetImage",
"ecr:GetDownloadUrlForLayer"
],
"Resource": "arn:aws:ecr:${Region}:${Account}:repository/${RepositoryName}"
},
{
"Effect": "Allow",
"Action": [
"ecs:RegisterContainerInstance",
"ecs:SubmitTaskStateChange"
],
"Resource": "arn:aws:ecs:${Region}:${Account}:cluster/${ClusterName}"
}
]
}
39 changes: 39 additions & 0 deletions bottlerocket/docs/permissions/ecs-resource-agent-create-role.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"ec2:DescribeSubnets",
"ec2:DescribeVpcs",
"ecs:CreateCluster"
],
"Resource": "*"
},
{
"Effect": "Allow",
"Action": [
"ecs:DeleteCluster",
"ecs:ListContainerInstances"
],
"Resource": "arn:aws:ecs:${Region}:${Account}:cluster/${ClusterName}"
},
{
"Effect": "Allow",
"Action": [
"iam:AddRoleToInstanceProfile",
"iam:CreateInstanceProfile",
"iam:GetInstanceProfile"
],
"Resource": "arn:aws:iam::${Account}:instance-profile/${InstanceProfileNameWithPath}"
},
{
"Effect": "Allow",
"Action": [
"iam:AttachRolePolicy",
"iam:CreateRole"
],
"Resource": "arn:aws:iam::${Account}:role/${RoleNameWithPath}"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"ec2:DescribeSubnets",
"ec2:DescribeVpcs",
"ecs:CreateCluster"
],
"Resource": "*"
},
{
"Effect": "Allow",
"Action": [
"ecs:DeleteCluster",
"ecs:ListContainerInstances"
],
"Resource": "arn:aws:ecs:${Region}:${Account}:cluster/${ClusterName}"
},
{
"Effect": "Allow",
"Action": "iam:GetInstanceProfile",
"Resource": "arn:aws:iam::${Account}:instance-profile/${InstanceProfileNameWithPath}"
}
]
}
25 changes: 25 additions & 0 deletions bottlerocket/docs/permissions/ecs-test-agent.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": "ecs:DescribeTaskDefinition",
"Resource": "*"
},
{
"Effect": "Allow",
"Action": "ecs:DescribeClusters",
"Resource": "arn:aws:ecs:${Region}:${Account}:cluster/${ClusterName}"
},
{
"Effect": "Allow",
"Action": "ecs:RunTask",
"Resource": "arn:aws:ecs:${Region}:${Account}:task-definition/${TaskDefinitionFamilyName}:${TaskDefinitionRevisionNumber}"
},
{
"Effect": "Allow",
"Action": "ecs:DescribeTasks",
"Resource": "arn:aws:ecs:${Region}:${Account}:task/${ClusterName}/${TaskId}"
}
]
}
28 changes: 28 additions & 0 deletions bottlerocket/docs/permissions/ecs-workload-agent.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"ecs:DescribeTaskDefinition",
"ecs:ListTaskDefinitions"
],
"Resource": "*"
},
{
"Effect": "Allow",
"Action": "ecs:DescribeClusters",
"Resource": "arn:aws:ecs:${Region}:${Account}:cluster/${ClusterName}"
},
{
"Effect": "Allow",
"Action": "ecs:RunTask",
"Resource": "arn:aws:ecs:${Region}:${Account}:task-definition/${TaskDefinitionFamilyName}:${TaskDefinitionRevisionNumber}"
},
{
"Effect": "Allow",
"Action": "ecs:DescribeTasks",
"Resource": "arn:aws:ecs:${Region}:${Account}:task/${ClusterName}/${TaskId}"
}
]
}
Loading

0 comments on commit b70c2b7

Please sign in to comment.