Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Phase2 Development #34

Merged
merged 27 commits into from
Jul 3, 2020
Merged

R4R: Phase2 Development #34

merged 27 commits into from
Jul 3, 2020

Conversation

HaoyangLiu
Copy link
Contributor

@HaoyangLiu HaoyangLiu commented Jul 3, 2020 •
edited
Loading

BUG FIXES

  • #9 Fix gov hub do not well handle when the target account is not contract

FEATURES

  • #7 Implement governance mechanism to update parameters in build-in system contract
  • #12 Implement token unbind mechanism
  • #21 Support miniToken cross chain transfer
  • #28 Add more events about token bind and transfer to facilitate reconciliation
  • #29 Implement a mechanism enable or disable channel through governance

IMPROVEMENTS

  • #3 Check sequence first to save gas for relayers
  • #13 Refactor cross chain architecture, communication layer: verify proof and manage sequence, application layer: focus on detailed application scenario
  • #14 Gov/Validator/Slash modification for refactor of cross chain mechanism
  • #19 Optimize rlp decoding and encoding library to save gas
  • #22 Add fail ack handler for transferOut
  • #24 Split tokenhub contract into tokenhub(for cross chain transfer) and tokenManager(for token bind and unbind)

HaoyangLiu and others added 27 commits July 3, 2020 15:44
check sequence first to save gas for relayer
05cce89
@unclezoro
fix unbonding all validator and total income mismatch
7035d28
@unclezoro
fix gov hub do not well handle when the target account is not contract
43485ac
@unclezoro
fix unproper error message when update params
b3c33ba
add transferOut sequence to refund package
7a8cf41
@unclezoro
R4R: Governance parameters (#7)
beb1ca4 
* gov tokenhub parameters

* add gov for RelayerIncentivize and TendermintLightClient

* add unit test for gov

update abi

resolve comment

* fix testcase

Co-authored-by: fudongbai <[email protected]>
implement unbind
bde4970
Refactor cross chain architecture, import rlp encoding and decoding a…
9309cb9 
…nd support minitoken transfer
@unclezoro
[R4F]Gov/Validator/Slash modification for refactor of cross chain mec…
7cd34d6 
…hanism (#14)

* update bsc validator set

* update for encode/decode of gov/validator/slash

* update template

* update testcase

* update testcase

* fix cases

* update testcase

* update

* update
update abis and lint, remove useless func
60f7394
@unclezoro
fix lint (#16)
6f00c00
@unclezoro
[R4R]only keep single relayer fee (#17)
7eb7efb 
* fix lint

* fix compile error

* only keep single relayer fee

* update
R4R: unify error code and improve unittests (#18)
8805481 
* improve tokenhub test

* unify error code and fix failed unittests

* add oracle sequence

* modify miniToken checker
@unclezoro
modify validator template to fix compile error (#20)
ba05bda
@unclezoro
fix missing import of template and fix miniToken checker issue
d582c13
add fail ack handler for transferOut and add unit tests (#22)
6ec7353
optimize rlp encode to save gas (#19)
a9f79f5
@unclezoro
R4R: split tokenhub (#24)
077af36 
* add onlyInit to public write method

* tokenhub payable and rename event

* move all library to lib

* split tokenhub into two contract

* change sync to syn

* transfer relayFee to tokenHUb

* add case for payload header

Co-authored-by: fudongbai <[email protected]>
R4R: mark some methods as read only (#25)
b93b615 
* mark some methods as read only

* update abis and detail bind failure reason
R4R: simplify bind parameters verification (#26)
130d4b5 
* simplify bind parameters verification

* fix bug in BNB refund amount calculation

* modify peggy amount calculation

* ensure tokenhub balance is less than locked amount
R4R: Refacor event and relay fee (#28)
ac76e86 
* add bindSuccess and bindFailure event

* enable more relayFee
@yutianwu @unclezoro
[R4R] Improve indent (#27)
3a53258 
* improve indent

* add additional improvements

* update genesis.json

* fix some other files

Co-authored-by: fudongbai <[email protected]>
R4R: enable or disable channel through governance (#29)
b4b2e92 
* enable and disable channel through governance

* fix a bug in batch oracle
add parameters to bind event to facilitate reconciliation
049396f
fix bug in disable channel when multiple channel shares one contract
d2926bf
allow more relay fee for bind and rename getRelayFee to getMiniRelayFee
8d800b9
Add changelog
1e15acf
@HaoyangLiu HaoyangLiu changed the title WIP: Phase2 Development R4R: Phase2 Development Jul 3, 2020
@HaoyangLiu HaoyangLiu requested a review from unclezoro July 3, 2020 08:16
@HaoyangLiu HaoyangLiu requested a review from yutianwu July 3, 2020 08:16
@unclezoro unclezoro merged commit 10925ed into master Jul 3, 2020
@unclezoro unclezoro deleted the develop branch August 8, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@yutianwu yutianwu yutianwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HaoyangLiu @yutianwu @unclezoro @fear22