R4R: simplify bind parameters verification #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HaoyangLiu
commented
Jun 18, 2020
•
HaoyangLiu
commented
- Simplify bind parameters verification
- Fix bug in BNB refund amount calculation
- Modify peggy amount calculation
HaoyangLiu
force-pushed
the
simplify-bind-parameter-verify
branch
from
4e0f917 to
4b51aa1
Compare
yutianwu
approved these changes
Jun 18, 2020
unclezoro
approved these changes
Jun 18, 2020
HaoyangLiu
pushed a commit
that referenced
this pull request
Jul 3, 2020
* simplify bind parameters verification * fix bug in BNB refund amount calculation * modify peggy amount calculation * ensure tokenhub balance is less than locked amount
HaoyangLiu
pushed a commit
that referenced
this pull request
Jul 3, 2020
* simplify bind parameters verification * fix bug in BNB refund amount calculation * modify peggy amount calculation * ensure tokenhub balance is less than locked amount
HaoyangLiu
pushed a commit
that referenced
this pull request
Jul 3, 2020
* simplify bind parameters verification * fix bug in BNB refund amount calculation * modify peggy amount calculation * ensure tokenhub balance is less than locked amount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.