Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: tools: scripts: red-pill: Add option to select user #2273

Merged
merged 1 commit into from
Dec 22, 2023
Merged

core: tools: scripts: red-pill: Add option to select user #2273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion core/tools/scripts/red-pill
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,44 @@
#!/bin/bash

usage() {
echo "Usage: $0 [-h] [-u user]"
echo
echo " -h, Show this help message"
echo " -u, Define a user (default: pi)"
exit 1
}

# Default values
user="pi"

while getopts ":hu:" opt; do
case ${opt} in
h )
usage
;;
u )
user=$OPTARG
;;
\? )
echo "Invalid Option: -$OPTARG" 1>&2
usage
;;
: )
echo "Invalid Option: -$OPTARG requires an argument" 1>&2
usage
;;
esac
done
shift $((OPTIND -1))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Don't simply ignore additional arguments
if [ $# -gt 0 ]; then
echo "Invalid Argument: $1" 1>&2
usage
fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I follow, what is the use case for this ?

Copy link
Member

@joaoantoniocardoso joaoantoniocardoso Dec 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redpill myusername would print the usage, instead of ignoring the argument. It's pretty common for people to miss the argument identifier (say, -u) before the argument.

It would also print the usage when redpill -u myusername and something else

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice!

# Don't simply ignore additional arguments
if [ $# -gt 0 ]; then
echo "Invalid Argument: $1" 1>&2
usage
fi

echo "You took the red pill."
echo "You stay in Wonderland, and I show you how deep the rabbit hole goes."
echo "Remember, all I'm offering is the truth. Nothing more."
echo "Exiting from docker, welcome to the real world."
ssh -i /root/.config/.ssh/id_rsa -o StrictHostKeyChecking=no pi@localhost
ssh -i /root/.config/.ssh/id_rsa -o StrictHostKeyChecking=no $user@localhost
Loading