core: tools: scripts: red-pill: Add option to select user #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
force-pushed
the
red-pill-2
branch
from
c853b16 to
b03a609
Compare
| esac | ||
| done | ||
| shift $((OPTIND -1)) | ||
|
|
There was a problem hiding this comment.
Suggested change
| # Don't simply ignore additional arguments | |
| if [ $# -gt 0 ]; then | |
| echo "Invalid Argument: $1" 1>&2 | |
| usage | |
| fi | |
There was a problem hiding this comment.
I'm not sure if I follow, what is the use case for this ?
There was a problem hiding this comment.
redpill myusername would print the usage, instead of ignoring the argument. It's pretty common for people to miss the argument identifier (say, -u) before the argument.
It would also print the usage when redpill -u myusername and something else
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
red-pill-2
branch
from
b03a609 to
977041f
Compare
|
Relevant to #1073 |
16 tasks
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.