Add a check for missing mesh in gltf #838
Conversation
Provide user an error rather than crashing when trying to draw the model
|
Reported here |
| @@ -530,6 +530,11 @@ bool lovrModelDataInitGltf(ModelData** result, Blob* source, ModelDataIO* io) { | |||
| } | |||
| } | |||
|
|
|||
| if (model->blobCount && !model->blobs) { | |||
There was a problem hiding this comment.
This broke all newModel calls for me, since model->blobs is always NULL here. For me, the model is importing fine but there's a crash during rendering. The vertex buffer was NULL during the vertex animation. I pushed 49e90aa to just skip vertex animation when there isn't a vertex buffer.
There was a problem hiding this comment.
Ah sorry. I first tried to assert on model->primitiveCount but then the cleanup would crash when releasing blobs, because I did it prematurely. Your method is cleaner.
There was a problem hiding this comment.
Ah I see. I think there is still an issue here with the error/cleanup code. Since blobCount/imageCount are set before blobs/images are assigned, if there is an error then lovrModelDataDestroy is going to try to free non-existent blobs/images. I'll see if I can improve it.
There was a problem hiding this comment.
Fixed up in 949b0ba, just need to ensure arrays exist before releasing their contents
Provide user an error rather than crashing when trying to draw the model