-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-15624 🍒 Align handling of no network states with iOS app. (#4431) #4439
PM-15624 🍒 Align handling of no network states with iOS app. (#4431) #4439
Conversation
(cherry picked from commit 7b7c2da)
New Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/hotfix-v2024.11.7 #4439 +/- ##
============================================================
Coverage ? 88.93%
============================================================
Files ? 453
Lines ? 39054
Branches ? 5511
============================================================
Hits ? 34734
Misses ? 2389
Partials ? 1931 ☔ View full report in Codecov by Sentry. |
@Test | ||
fun `in add mode, SaveClick createCipher error should show error dialog`() = runTest { | ||
fun `in add mode, SaveClick with no network connection error should show error dialog`() = runTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is too long then the runTest {
should wrap
(cherry picked from commit 7b7c2da)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15624
📔 Objective
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes