Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-15624 🍒 Align handling of no network states with iOS app. (#4431) #4439

Merged

Conversation

dseverns-livefront
Copy link
Collaborator

(cherry picked from commit 7b7c2da)

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15624

📔 Objective

  • Cherry pick into hotfix branch

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Logo
Checkmarx One – Scan Summary & Detailsf1831469-10f4-4f3c-b0cf-226bcb23f5fa

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 29 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt: 94 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 240 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 251 Attack Vector
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 262 Attack Vector
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Use_of_Hardcoded_Password /app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20 Attack Vector

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 70.51282% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/hotfix-v2024.11.7@0413cdc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../ui/vault/feature/addedit/VaultAddEditViewModel.kt 52.17% 10 Missing and 1 partial ⚠️
.../platform/feature/settings/other/OtherViewModel.kt 66.66% 7 Missing ⚠️
.../ui/platform/feature/settings/other/OtherScreen.kt 28.57% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             release/hotfix-v2024.11.7    #4439   +/-   ##
============================================================
  Coverage                             ?   88.93%           
============================================================
  Files                                ?      453           
  Lines                                ?    39054           
  Branches                             ?     5511           
============================================================
  Hits                                 ?    34734           
  Misses                               ?     2389           
  Partials                             ?     1931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Test
fun `in add mode, SaveClick createCipher error should show error dialog`() = runTest {
fun `in add mode, SaveClick with no network connection error should show error dialog`() = runTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is too long then the runTest { should wrap

@dseverns-livefront dseverns-livefront merged commit b32c593 into release/hotfix-v2024.11.7 Dec 9, 2024
8 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-15624-nonetwork-hotfix branch December 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants