-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-15624 Align handling of no network states with iOS app. #4431
Conversation
…Vault,Send, and Sync
New Issues
Fixed Issues
|
userData: UserState?, | ||
): VaultAddEditState { | ||
val internalVaultData = vaultData | ||
.takeUnless { it == null } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
takeUnless { it == null }
is not necessary. Could just be vaultData ?: VaultData(...)
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4431 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
(cherry picked from commit 7b7c2da)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15624
📔 Objective
When the following actions occur the response should be:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes