Missing FC Typenames (core issue #1217) #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
changed the title
pmconrad
suggested changes
Aug 11, 2018
include/fc/reflect/typename.hpp
Outdated
| { | ||
| static const char* name() | ||
| { | ||
| return (std::string("fc::smart_ref<") + get_typename<T>::name() + std::string(">")).c_str(); |
There was a problem hiding this comment.
Must assign to static string n first, then return that.
There was a problem hiding this comment.
My oversight. Thank you for catching that.
|
Just a note: when porting code from sibling projects, prefer cherry-pick + fix conflicts to copy + paste + fix. (For this PR, perhaps unable to cherry-pick due to different directory structures?) |
|
@abitmore Did not attempt to cherry-pick. Will attempt that from now on. Thanks. |
pmconrad
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fc portion of bitshares/bitshares-core#1217
Prior get_typename was generating classes on many unnecessary classes. This modification correctly generates code for only the classes necessary.