Missing FC Typenames (Issue #1217) #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: waiting for fc bump |
abitmore
reviewed
Aug 11, 2018
| static const char* name() | ||
| { | ||
| return (std::string("graphene::chain::extension<") | ||
| + fc::get_typename<T>::name() + std::string(">")).c_str(); |
There was a problem hiding this comment.
Need to change to static n here as well?
There was a problem hiding this comment.
Yes. Done. Thanks.
|
I'm happy to bump FC as part of this ticket. Is that the way it should be done, or in a separate PR? Thanks. |
Yes. |
|
I think that needs a stronger bump. :-) |
|
Note: this includes the fix for #1244 |
pmconrad
approved these changes
Aug 17, 2018
This was referenced Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the core portion of #1217, and works with PR bitshares/bitshares-fc#74
Prior get_typename was generating classes on many unnecessary classes. This modification correctly generates code for only the classes necessary.