Downgrade tiny-bip39 to version prior to 0.8.0 #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required until BDK MSRV is changed to 1.51 or we replace tiny-bip39 dependency.
notmandatory
force-pushed
the
downgrade_zeroize_derive
branch
from
f251508 to
8c21bcf
Compare
notmandatory
changed the title
|
I will also cherry-pick this into the |
4 tasks
afilini
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is required until BDK MSRV is changed to 1.51 or we replace the
tiny-bip39dependency (see #399).Notes to the reviewers
We were able to fix this issue with
zeroize_deriveby downgrading it to version1.1.0but that version was yanked from crates.io two days ago. So now I'm downgradingtiny-bip39to a version prior to 0.8.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing