-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a different BIP39 implementation #399
Comments
Can we switch to https://github.com/rust-bitcoin/rust-bip39? it's MSRV is 1.29. |
Yeah I guess it makes sense, I'm gonna reopen this issue to keep track of that |
all-keys
features
I did a preliminary look at swapping |
As commented in |
|
I am willing to work on this.. Does it make sense to implement our own bip39? Should not be too difficult. If yes I can start sketching one. |
I looked into rust-bip39 and it seems it should be possible to use that with slight refactoring of our I am working on the transition. Should not take long. |
Sounds great if we can use |
The
tiny-bip39
dependency used in theall-keys
feature depends onzeroize
which appears to only support MSRV 1.51+https://github.com/iqlusioninc/crates/
This is causing the following error in our CI workflow:
https://github.com/bitcoindevkit/bdk/runs/3101954688?check_suite_focus=true
The text was updated successfully, but these errors were encountered: