Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml: Add DropShadow to the OptionSwitch indicatorButton #132

Closed
wants to merge 1 commit into from

Conversation

shaavan
Copy link
Contributor

@shaavan shaavan commented Jun 20, 2022

Ported #111 to this PR.

This PR rebase #111 on the current master.

Notes:

  • I successfully compiled the updated PR on Ubuntu 22.04 using Qt version 5.15.3.
  • To successfully compile and run the PR, I had to install an additional library.
sudo apt install qml-module-qtgraphicaleffects
  • I have created a convenient demo for checking that the drop shadow works correctly. Drop Shadow onboarding test branch cherry-picks this PR over the Onboarding views #124.
  • If, in the demo, the color of the drop shadow is too subtle to perceive, try experimenting with changing the color of the drop shadow to get high contrast. For example:
             spread: 0.0
             samples: 21
-            color: "#00000040"
+            color: "#7900fffc"
             source: indicatorButton
         }
     }

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because you have to allow static builds to pull in these plugins, here's an example on how to accomplish this: https://github.com/bitcoin-core/gui-qml/pull/45/files

@hebasto
Copy link
Member

hebasto commented Jun 26, 2022

@shaavan

Could you post screenshots please?

Also I'd like to have some Concept ACKs from designers before introducing a new plugin.

@@ -42,6 +42,8 @@ QT_END_NAMESPACE

#if defined(QT_STATICPLUGIN)
#include <QtPlugin>
Q_IMPORT_PLUGIN(QtGraphicalEffectsPlugin)
Q_IMPORT_PLUGIN(QtGraphicalEffectsPrivatePlugin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why importing of private plugin is required?

@shaavan
Copy link
Contributor Author

shaavan commented Jul 1, 2022

In the recent Bitcoin Core App Design Call on 06-29-2022, it was discussed the need to introduce a dependency qml-module-qtgraphicaleffects for the DropShadow is not worthwhile. And hence, adding DropShadow should be postponed until the same dependency is used for some other important task.

So I shall be closing this PR until later.

@shaavan shaavan closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants