-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml: Add DropShadow to the OptionSwitch indicatorButton #111
Conversation
Running the current version of the PR will cause the following error.
And to create dropShadow, we require this module. I tried to figure out some workaround, but I thought it's better to ask and go with the correct approach on the get-go. |
e2d1635
to
2e8b096
Compare
Updated from e2d1635 to 2e8b096. Changes:
Diff: diff --git a/src/qml/components/ConnectionSettings.qml b/src/qml/components/ConnectionSettings.qml
index 090e8e793..35f8e5d3a 100644
--- a/src/qml/components/ConnectionSettings.qml
+++ b/src/qml/components/ConnectionSettings.qml
@@ -15,21 +15,21 @@ ColumnLayout {
}
Setting {
Layout.fillWidth: true
- header: qsTr("Daily upload limit")
+ header: qsTr("Daily upload limit")
}
Setting {
Layout.fillWidth: true
- header: qsTr("Connection limit")
+ header: qsTr("Connection limit")
}
Setting {
Layout.fillWidth: true
- header: qsTr("Listening enabled")
- description: qsTr("Reduces data usage.")
+ header: qsTr("Listening enabled")
+ description: qsTr("Reduces data usage.")
}
Setting {
last: true
Layout.fillWidth: true
- header: qsTr("Blocks Only")
- description: qsTr("Do not transfer unconfirmed transactions. Also disabled listening.")
+ header: qsTr("Blocks Only")
+ description: qsTr("Do not transfer unconfirmed transactions. Also disabled listening.")
}
}
|
@shaavan try adding Q_IMPORT_PLUGIN(QtGraphicalEffectsPlugin)
Q_IMPORT_PLUGIN(QtGraphicalEffectsPrivatePlugin) Lines 43 to 52 in ef98ffa
|
2e8b096
to
109682b
Compare
Updated from 2e8b096 to 109682b (pr111.01 -> pr112.02) Changes:
The PR is still in WIP. Currently, using the Q_IMPORT_PLUGIN caused the following error.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shaavan as properly supporting this requires OpenGL support, let's leave the dropshadows for later.
I understand. I shall close this PR for now. We can restart work on this once OpenGL support is appropriately integrated. |
This PR is moved to #132. Rationale:
|
indicatorButton
, as per the main design file of the project.Some points to note:
===
instead of==
to avoid type coercion.