Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with trade messages pocessed out of order #3230

Conversation

HenrikJannsen
Copy link
Contributor

No description provided.

…gMessages set and reprocess it at next message.

This covers the case when the maker is offline while the taker/buyer takes the offer and sends the btc address. The maker once going online receives both as mailbox message without guaranteed order, and if the btc address message was processed first, it is dropped as it cannot be used to create a new channel.
…ngMessages set and reprocess it at next message.

This covers the case when the maker is offline while the taker/buyer takes the offer and sends the btc address. The maker once going online receives both as mailbox message without guaranteed order, and if the btc address message was processed first, it is dropped as no protocol was yet created.
Copy link
Contributor

@axpoems axpoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen merged commit 5d02d6c into bisq-network:main Feb 23, 2025
15 checks passed
@HenrikJannsen HenrikJannsen deleted the fix-bug-with-trade-messages-pocessed-out-of-order branch February 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants