Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade workflow is not working properly #3217

Closed
MPins opened this issue Feb 16, 2025 · 11 comments
Closed

Trade workflow is not working properly #3217

MPins opened this issue Feb 16, 2025 · 11 comments
Labels
bug Something isn't working network P2P network, messaging, distributed data storage trading

Comments

@MPins
Copy link

MPins commented Feb 16, 2025

After installing 2.1.6, I had three trades as a maker where the workflow did not work properly.

The buyer informed the invoice or the btc address and informed that the payment was initiated, but my Bisq2 keeps presenting the message "Wait for the buyer's payment".

@HenrikJannsen HenrikJannsen added bug Something isn't working network P2P network, messaging, distributed data storage trading labels Feb 17, 2025
@HenrikJannsen
Copy link
Contributor

Did you have a stable network connection? Did you try to restart Bisq?

@igorfp25
Copy link

I am having the same issue. Connection is stable and I have tried restarting it, did not help.

@MPins
Copy link
Author

MPins commented Feb 20, 2025

The same here.

@HenrikJannsen
Copy link
Contributor

I am having the same issue. Connection is stable and I have tried restarting it, did not help.

You had it also repeatedly?

@igorfp25
Copy link

igorfp25 commented Feb 21, 2025

I am having the same issue. Connection is stable and I have tried restarting it, did not help.

You had it also repeatedly?

well, since I updated to version 2.1.6, I engaged in 2 trades, once as a buyer/taker, once as a seller/maker. It happened in both.

@HenrikJannsen
Copy link
Contributor

I am having the same issue. Connection is stable and I have tried restarting it, did not help.

You had it also repeatedly?

well, since I updated to version 2.1.6, I engaged in 2 trades, once as a buyer/taker, once as a seller/maker. It happened in both.

Did you had your computer online the whole time? I guess its a bug with mailbox messages (which are used in case the peer is offline)

@igorfp25
Copy link

Did you had your computer online the whole time? I guess its a bug with mailbox messages (which are used in case the peer is offline)

As a taker > I initiated the trade, the maker was offline, during which I made the fiat payment then went offline for hours waiting for the maker to confirm.
As a maker > the trade initiated while I was offline, After I logged in, I stayed online the whole time until the "end" of the trade (not sure about the other party, but he seemed to be online for the most part)

@MPins
Copy link
Author

MPins commented Feb 21, 2025

I am having the same issue. Connection is stable and I have tried restarting it, did not help.

You had it also repeatedly?

well, since I updated to version 2.1.6, I engaged in 2 trades, once as a buyer/taker, once as a seller/maker. It happened in both.

Did you had your computer online the whole time? I guess its a bug with mailbox messages (which are used in case the peer is offline)

I think it is a good guess ... Every time I had this problem (it was 4 times) ... My computer was offline or in standby.

@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Feb 21, 2025

I found the bug. When the maker is offline and the taker sends the btc address data after taking the offer, the 2 messages (take offer message, btcAddressMessage) arrive as mailbox messages without order and if the btcAddressMessage is processed first it was dropped as there is no trade yet created. Will fix that soon and maybe we do a new release soon as its a critical bug.
Thanks for reporting and the details.

@HenrikJannsen
Copy link
Contributor

Fixed with #3230

@HenrikJannsen
Copy link
Contributor

We will work on the new release soon. I guess 1-2 weeks the new release should be ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working network P2P network, messaging, distributed data storage trading
Projects
None yet
Development

No branches or pull requests

3 participants