Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in TradeParty's protobuf encoding #1595

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix bug in TradeParty's protobuf encoding #1595

merged 1 commit into from
Jan 20, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Jan 18, 2024 •
edited
Loading

This was preventing the verification of the taker's signature data on the BisqEasyTakeOfferResponseHandler when done asynchronously.

HenrikJannsen
HenrikJannsen approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Ah good that spotted that bug!

alvasw
alvasw approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 8196893 into bisq-network:main Jan 20, 2024
15 checks passed
@axpoems axpoems mentioned this pull request Jan 24, 2024
Closed
@axpoems axpoems deleted the fix-TradyParty-protobuf branch January 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvasw alvasw alvasw approved these changes

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axpoems @alvasw @HenrikJannsen