Merge pull request #1595 from axpoems/fix-TradyParty-protobuf

Fix bug in TradeParty's protobuf encoding
bisq-network · Jan 20, 2024 · 8196893 · 8196893
2 parents fc02432 + 757949d
commit 8196893
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/trade/src/main/java/bisq/trade/TradeParty.java b/trade/src/main/java/bisq/trade/TradeParty.java
@@ -49,7 +49,8 @@ protected TradeParty(NetworkId networkId) {
     public bisq.trade.protobuf.TradeParty.Builder getTradePartyBuilder() {
         bisq.trade.protobuf.TradeParty.Builder builder = bisq.trade.protobuf.TradeParty.newBuilder()
                 .setNetworkId(networkId.toProto());
-        Optional.ofNullable(contractSignatureData.get()).ifPresent(ContractSignatureData::toProto);
+        Optional.ofNullable(contractSignatureData.get())
+                .ifPresent(contractSignatureData -> builder.setContractSignatureData(contractSignatureData.toProto()));
         return builder;
     }
 

diff --git a/...rc/main/java/bisq/trade/bisq_easy/protocol/messages/BisqEasyTakeOfferResponseHandler.java b/...rc/main/java/bisq/trade/bisq_easy/protocol/messages/BisqEasyTakeOfferResponseHandler.java
@@ -47,7 +47,7 @@ public void handle(Event event) {
 
     @Override
     protected void verifyMessage(BisqEasyTakeOfferResponse message) {
-       super.verifyMessage(message);
+        super.verifyMessage(message);
 
         ContractSignatureData makersContractSignatureData = message.getContractSignatureData();
         ContractSignatureData takersContractSignatureData = trade.getTaker().getContractSignatureData().get();