Improve XMR subaddress popup behaviour #7378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alvasw
commented
Feb 5, 2025
alvasw
commented
- Show XMR subaddress popup if user has non-subaddress account
- Before PR Only show XMR subaddress recommendation if the user has a XMR account setup #7123, we showed the XMR subaddress popup whenever the user navigated to the account tab. After PR Only show XMR subaddress recommendation if the user has a XMR account setup #7123, we show the XMR subaddress popup if the user has an XMR account. However, it's better show the popup if the user has a non-subaddress XMR account.
- Show XMR subaddress popup during account creation
- Additionally show the XMR subaddress popup during account creation, so that user can look up how subaddresses work and set it up.
- Refactor duplicate XMR subaddress popup code
Before PR bisq-network#7123, we showed the XMR subaddress popup whenever the user naviated to the account tab. After PR bisq-network#7123, we show the XMR subaddress popup if the user has an XMR account. However, it's better show the popup if the user has a non-subaddress XMR account.
Additionally show the XMR subaddress popup during account creation, so that user can look up how subaddresses work and set it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.