Refactor duplicate XMR subaddress popup code

bisq-network · Feb 5, 2025 · 861f655 · 861f655
1 parent 5e04336
commit 861f655
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/desktop/src/main/java/bisq/desktop/components/paymentmethods/XmrForm.java b/desktop/src/main/java/bisq/desktop/components/paymentmethods/XmrForm.java
@@ -204,12 +204,7 @@ public void addFormForAddAccount() {
         addLimitations(false);
         addAccountNameTextFieldWithAutoFillToggleButton();
 
-        new Popup()
-                .headLine(Res.get("account.altcoin.popup.xmr.dataDirWarningHeadline"))
-                .backgroundInfo(Res.get("account.altcoin.popup.xmr.dataDirWarning"))
-                .dontShowAgainId("accountSubAddressInfo")
-                .width(700)
-                .show();
+        showXmrSubAddressPopup();
     }
 
     void setFieldManagement(boolean useSubAddresses) {
@@ -369,6 +364,15 @@ public void updateAllInputsValid() {
         }
     }
 
+    public static void showXmrSubAddressPopup() {
+        new Popup()
+                .headLine(Res.get("account.altcoin.popup.xmr.dataDirWarningHeadline"))
+                .backgroundInfo(Res.get("account.altcoin.popup.xmr.dataDirWarning"))
+                .dontShowAgainId("accountSubAddressInfo")
+                .width(700)
+                .show();
+    }
+
     private void maybeShowXmrSubAddressInfo() {
         String key = "xmrSubAddressInfo";
         if (DontShowAgainLookup.showAgain(key)) {

diff --git a/...main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java b/...main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java
@@ -18,11 +18,10 @@
 package bisq.desktop.main.account.content.altcoinaccounts;
 
 import bisq.desktop.common.model.ActivatableDataModel;
-import bisq.desktop.main.overlays.popups.Popup;
+import bisq.desktop.components.paymentmethods.XmrForm;
 import bisq.desktop.util.GUIUtil;
 
 import bisq.core.locale.CryptoCurrency;
-import bisq.core.locale.Res;
 import bisq.core.locale.TradeCurrency;
 import bisq.core.offer.OpenOfferManager;
 import bisq.core.payment.AssetAccount;
@@ -85,12 +84,7 @@ protected void activate() {
                 .filter(e -> e.getSingleTradeCurrency().getCode().equals("XMR"))
                 .forEach(e -> {
                     if (!xmrAccountUsesSubAddresses(e)) {
-                        new Popup()
-                                .headLine(Res.get("account.altcoin.popup.xmr.dataDirWarningHeadline"))
-                                .backgroundInfo(Res.get("account.altcoin.popup.xmr.dataDirWarning"))
-                                .dontShowAgainId("accountSubAddressInfo")
-                                .width(700)
-                                .show();
+                        XmrForm.showXmrSubAddressPopup();
                     }
                 });
     }