Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): make useSelfClosingElements safe and improve error message #4998

Merged

Conversation

mehm8128
Copy link
Contributor

Summary

close #4966

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Jan 30, 2025
@mehm8128 mehm8128 force-pushed the feat/make_use_self_closing_elements_rule_safe branch from dafa1e9 to 2bee3e4 Compare January 30, 2025 14:16
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #4998 will not alter performance

Comparing mehm8128:feat/make_use_self_closing_elements_rule_safe (fb9722c) with next (d76e8d3)

Summary

✅ 95 untouched benchmarks

@dyc3
Copy link
Contributor

dyc3 commented Jan 30, 2025

Can you rebase this against the next branch instead? Also, see the contributing guide on that branch for how to add a new changeset.

@mehm8128 mehm8128 force-pushed the feat/make_use_self_closing_elements_rule_safe branch from 2bee3e4 to e6327f6 Compare January 30, 2025 15:10
@mehm8128 mehm8128 changed the base branch from main to next January 30, 2025 15:10
@mehm8128 mehm8128 force-pushed the feat/make_use_self_closing_elements_rule_safe branch from e6327f6 to fb9722c Compare January 30, 2025 15:18
@github-actions github-actions bot removed the A-Changelog Area: changelog label Jan 30, 2025
@mehm8128
Copy link
Contributor Author

@dyc3
Thank you, I hadn't caught up about next branch and the new way to write change log!
I fixed and now it is ready for review!

@dyc3 dyc3 merged commit f0e6521 into biomejs:next Jan 30, 2025
12 checks passed
@mehm8128 mehm8128 deleted the feat/make_use_self_closing_elements_rule_safe branch January 30, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Make fix of useSelfClosingElements safe
2 participants