Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Make fix of useSelfClosingElements safe #4966

Closed
ematipico opened this issue Jan 24, 2025 · 1 comment · Fixed by #4998
Closed

📎 Make fix of useSelfClosingElements safe #4966

ematipico opened this issue Jan 24, 2025 · 1 comment · Fixed by #4998
Assignees
@mehm8128
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@ematipico
Copy link
Member

ematipico commented Jan 24, 2025 •
edited
Loading

Description

This was brought up in biomejs/website#1708

We should update the rule and:

  • provide better documentation (we could borrow some text form the diagnostic)
  • make the fix safe
  • update the code action text. At the moment is Use a SelfClosingElement instead, and it should use a self-closing element instead.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide.
@ematipico ematipico added good first issue Good for newcomers S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 24, 2025
@mehm8128
Copy link
Contributor

@ematipico
Hi, I'm interested in this issue, could you assign it to me?

@mehm8128 mehm8128 mentioned this issue Jan 30, 2025
Merged
@dyc3 dyc3 closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehm8128 mehm8128

Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lint): make useSelfClosingElements safe and improve error message mehm8128/biome
3 participants
@ematipico @dyc3 @mehm8128