Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen,css_parser,css_formatter): rename % from remainder to percent in CSS #1398

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

faultyserver
Copy link
Contributor

Summary

I'd noticed previously that there was a typo in reminder for the name of the % as a token in the generated syntax, so I went in to rename it originally. But then I also figured that in CSS, the % is more literally used as a percentage rather than a remainder operation, so I decided to rename it as such in CSS.

Test Plan

Updated the snapshots and formatter to use the new name.

Copy link

netlify bot commented Jan 1, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 629101f
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65933e4195575f000809b061

@faultyserver faultyserver changed the title fix(xtask,css_parser,css_formatter): rename % from remainder to percent in CSS fix(codegen,css_parser,css_formatter): rename % from remainder to percent in CSS Jan 1, 2024
@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels Jan 1, 2024
Copy link
Contributor

github-actions bot commented Jan 1, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

Copy link

codspeed-hq bot commented Jan 1, 2024

CodSpeed Performance Report

Merging #1398 will create unknown performance changes

⚠️ No base runs were found

Falling back to comparing faulty/css-fix-remainder (629101f) with main (658ffe9)

Summary

🆕 16 new benchmarks
⁉️ 16 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main faulty/css-fix-remainder Change
🆕 bootstrap.css[uncached] N/A 260.1 ms N/A
🆕 bootstrap.css[cached] N/A 240.8 ms N/A
🆕 full.css[cached] N/A 2.4 s N/A
🆕 materialize.css[uncached] N/A 183.5 ms N/A
🆕 materialize.css[cached] N/A 171.7 ms N/A
🆕 bulma.css[cached] N/A 240.8 ms N/A
🆕 semantic.css[cached] N/A 730.6 ms N/A
🆕 foundation.css[cached] N/A 156.3 ms N/A
🆕 bulma.css[uncached] N/A 260.2 ms N/A
🆕 foundation.css[uncached] N/A 169.7 ms N/A
🆕 full.css[uncached] N/A 2.5 s N/A
🆕 tachyons.css[uncached] N/A 125 ms N/A
🆕 semantic.css[uncached] N/A 777.7 ms N/A
🆕 pure.css[cached] N/A 20.2 ms N/A
🆕 pure.css[uncached] N/A 23 ms N/A
🆕 tachyons.css[cached] N/A 108.7 ms N/A
⁉️ js_formatter[react.production.min.js] 40.9 ms N/A N/A
⁉️ js_formatter[compiler.js] 2.9 s N/A N/A
⁉️ js_formatter[react-dom.production.min.js] 803.1 ms N/A N/A
⁉️ js_formatter[jquery.min.js] 674.5 ms N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@faultyserver faultyserver merged commit 0b116f2 into main Jan 1, 2024
20 of 21 checks passed
@faultyserver faultyserver deleted the faulty/css-fix-remainder branch January 1, 2024 22:58
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants