Skip to content

Commit

Permalink
fix(codegen,css_parser,css_formatter): rename % from remainder to p…
Browse files Browse the repository at this point in the history 
…ercent in CSS (#1398)
  • Loading branch information
@faultyserver
faultyserver authored Jan 1, 2024
1 parent 9c0243f commit 0b116f2
Show file tree
Hide file tree
Showing 11 changed files with 74 additions and 73 deletions.
4 changes: 2 additions & 2 deletions crates/biome_css_factory/src/generated/node_factory.rs
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/biome_css_formatter/src/css/value/percentage.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ impl FormatNodeRule<CssPercentage> for FormatCssPercentage {
fn fmt_fields(&self, node: &CssPercentage, f: &mut CssFormatter) -> FormatResult<()> {
let CssPercentageFields {
value_token,
reminder_token,
percent_token,
} = node.as_fields();

write!(f, [value_token.format(), reminder_token.format()])
write!(f, [value_token.format(), percent_token.format()])
}
}
22 changes: 11 additions & 11 deletions crates/biome_css_parser/tests/css_test_suite/error/at_rule/at_rule_keyframes.css.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@45..46 "0" [] [],
reminder_token: PERCENT@46..47 "%" [] [],
percent_token: PERCENT@46..47 "%" [] [],
},
],
},
Expand Down Expand Up @@ -168,7 +168,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@84..87 "100" [] [],
reminder_token: PERCENT@87..88 "%" [] [],
percent_token: PERCENT@87..88 "%" [] [],
},
],
},
Expand Down Expand Up @@ -222,7 +222,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@145..146 "0" [] [],
reminder_token: PERCENT@146..147 "%" [] [],
percent_token: PERCENT@146..147 "%" [] [],
},
],
},
Expand Down Expand Up @@ -283,7 +283,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@212..215 "100" [] [],
reminder_token: PERCENT@215..216 "%" [] [],
percent_token: PERCENT@215..216 "%" [] [],
},
],
},
Expand Down Expand Up @@ -343,7 +343,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@279..280 "0" [] [],
reminder_token: PERCENT@280..281 "%" [] [],
percent_token: PERCENT@280..281 "%" [] [],
},
],
},
Expand Down Expand Up @@ -402,7 +402,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@343..344 "0" [] [],
reminder_token: PERCENT@344..345 "%" [] [],
percent_token: PERCENT@344..345 "%" [] [],
},
],
},
Expand Down Expand Up @@ -474,7 +474,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@444..445 "0" [] [],
reminder_token: PERCENT@445..446 "%" [] [],
percent_token: PERCENT@445..446 "%" [] [],
},
},
missing separator,
Expand Down Expand Up @@ -510,7 +510,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@483..486 "100" [] [],
reminder_token: PERCENT@486..487 "%" [] [],
percent_token: PERCENT@486..487 "%" [] [],
},
],
},
Expand Down Expand Up @@ -570,7 +570,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@549..550 "0" [] [],
reminder_token: PERCENT@550..551 "%" [] [],
percent_token: PERCENT@550..551 "%" [] [],
},
],
},
Expand Down Expand Up @@ -604,7 +604,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@586..589 "100" [] [],
reminder_token: PERCENT@589..590 "%" [] [],
percent_token: PERCENT@589..590 "%" [] [],
},
},
missing separator,
Expand Down Expand Up @@ -678,7 +678,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@691..694 "100" [] [],
reminder_token: PERCENT@694..695 "%" [] [],
percent_token: PERCENT@694..695 "%" [] [],
},
],
},
Expand Down
24 changes: 12 additions & 12 deletions crates/biome_css_parser/tests/css_test_suite/ok/at_rule/at_rule_keyframe.css.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@149..150 "0" [] [],
reminder_token: PERCENT@150..151 "%" [] [],
percent_token: PERCENT@150..151 "%" [] [],
},
],
},
Expand Down Expand Up @@ -190,7 +190,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@188..191 "100" [] [],
reminder_token: PERCENT@191..192 "%" [] [],
percent_token: PERCENT@191..192 "%" [] [],
},
],
},
Expand Down Expand Up @@ -226,7 +226,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@228..231 "0" [Newline("\n"), Whitespace("\t")] [],
reminder_token: PERCENT@231..233 "%" [] [Whitespace(" ")],
percent_token: PERCENT@231..233 "%" [] [Whitespace(" ")],
},
},
],
Expand Down Expand Up @@ -268,7 +268,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@253..257 "30" [Newline("\n"), Whitespace("\t")] [],
reminder_token: PERCENT@257..259 "%" [] [Whitespace(" ")],
percent_token: PERCENT@257..259 "%" [] [Whitespace(" ")],
},
},
],
Expand Down Expand Up @@ -298,14 +298,14 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@273..277 "68" [Newline("\n"), Whitespace("\t")] [],
reminder_token: PERCENT@277..278 "%" [] [],
percent_token: PERCENT@277..278 "%" [] [],
},
},
COMMA@278..280 "," [] [Whitespace(" ")],
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@280..282 "72" [] [],
reminder_token: PERCENT@282..284 "%" [] [Whitespace(" ")],
percent_token: PERCENT@282..284 "%" [] [Whitespace(" ")],
},
},
],
Expand Down Expand Up @@ -335,7 +335,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@299..304 "100" [Newline("\n"), Whitespace("\t")] [],
reminder_token: PERCENT@304..306 "%" [] [Whitespace(" ")],
percent_token: PERCENT@304..306 "%" [] [Whitespace(" ")],
},
},
],
Expand Down Expand Up @@ -364,7 +364,7 @@ CssRoot {
value: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@326..329 "100" [] [],
reminder_token: PERCENT@329..330 "%" [] [],
percent_token: PERCENT@329..330 "%" [] [],
},
],
important: missing (optional),
Expand Down Expand Up @@ -463,7 +463,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@467..472 "50" [Newline("\n"), Newline("\n"), Whitespace("\t")] [],
reminder_token: PERCENT@472..474 "%" [] [Whitespace(" ")],
percent_token: PERCENT@472..474 "%" [] [Whitespace(" ")],
},
},
],
Expand Down Expand Up @@ -506,7 +506,7 @@ CssRoot {
CssKeyframesPercentageSelector {
selector: CssPercentage {
value_token: CSS_NUMBER_LITERAL@514..519 "50" [Newline("\n"), Newline("\n"), Whitespace("\t")] [],
reminder_token: PERCENT@519..521 "%" [] [Whitespace(" ")],
percent_token: PERCENT@519..521 "%" [] [Whitespace(" ")],
},
},
],
Expand Down Expand Up @@ -598,7 +598,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@639..640 "0" [] [],
reminder_token: PERCENT@640..641 "%" [] [],
percent_token: PERCENT@640..641 "%" [] [],
},
],
},
Expand Down Expand Up @@ -640,7 +640,7 @@ CssRoot {
css_component_value_list: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@678..681 "100" [] [],
reminder_token: PERCENT@681..682 "%" [] [],
percent_token: PERCENT@681..682 "%" [] [],
},
],
},
Expand Down
4 changes: 2 additions & 2 deletions crates/biome_css_parser/tests/css_test_suite/ok/at_rule/at_rule_layer.css.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ CssRoot {
value: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@158..162 "-100" [] [],
reminder_token: PERCENT@162..164 "%" [] [Whitespace(" ")],
percent_token: PERCENT@162..164 "%" [] [Whitespace(" ")],
},
CssNumber {
value_token: CSS_NUMBER_LITERAL@164..165 "0" [] [],
Expand Down Expand Up @@ -308,7 +308,7 @@ CssRoot {
value: CssComponentValueList [
CssPercentage {
value_token: CSS_NUMBER_LITERAL@266..270 "-100" [] [],
reminder_token: PERCENT@270..271 "%" [] [],
percent_token: PERCENT@270..271 "%" [] [],
},
],
important: missing (optional),
Expand Down
Loading

0 comments on commit 0b116f2

Please sign in to comment.