Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CANNOLI-55] Fix compile errors due to upstream commit 0afbda96. #57

Merged
merged 1 commit into from
Jul 13, 2017
Merged

[CANNOLI-55] Fix compile errors due to upstream commit 0afbda96. #57

merged 1 commit into from
Jul 13, 2017

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Jul 13, 2017

Fixes #55

@heuermh heuermh mentioned this pull request Jul 13, 2017
Closed
@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 34.643% when pulling 10ad0c9 on heuermh:issue-55-take-two into 7a098f6 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/45/
Test PASSed.

fnothaft
fnothaft reviewed Jul 13, 2017
View reviewed changes
src/main/scala/org/bdgenomics/cannoli/util/QuerynameGrouper.scala
@@ -29,9 +29,8 @@ private[cannoli] object QuerynameGrouper extends Serializable {
}

def apply(rdd: AlignmentRecordRDD): FragmentRDD = {
new FragmentRDD(apply(rdd.rdd),
FragmentRDD(apply(rdd.rdd),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can wait for bigdatagenomics/adam#1598, we can use transmute instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannoli head is broken (and I get a dozen emails from Jenkins every morning to prove it), so I'd rather get this in first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, but what I'm getting at is that we're waiting for you to review/merge bigdatagenomics/adam#1598. Then, all the broken code can go away. ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know ... but that pull request is very interesting and has me thinking. This change has +/- 19 LOC, that one has +/- 2824 LOC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@fnothaft fnothaft merged commit 560789a into bigdatagenomics:master Jul 13, 2017
@fnothaft
Copy link
Member

Thanks @heuermh!

@heuermh heuermh deleted the issue-55-take-two branch July 13, 2017 17:11
@heuermh heuermh added this to the 0.1.0 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnothaft fnothaft fnothaft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heuermh @coveralls @AmplabJenkins @fnothaft