Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory name escaping #191

Merged
merged 3 commits into from
Aug 22, 2018
Merged

Fix directory name escaping #191

merged 3 commits into from
Aug 22, 2018

Conversation

RReverser
Copy link
Contributor

@RReverser RReverser commented Aug 17, 2018

Fixes various issues related to directory name escaping.

Before:

├── g.r{ou
│   └── p
│       ├── report
│       └── t{e.s
│           └── t
│               └── report
├── g_r{ou_p
│   └── t{e_s_t
│       ├── _a_b_
│       │   ├── base
│       │   ├── new
│       │   └── report
│       └── _c{d_
│           ├── base
│           ├── new
│           └── report
└── report

After:

├── g.r{ou_p
│   ├── report
│   └── t{e.s_t
│       ├── _a_b_
│       │   ├── base
│       │   ├── new
│       │   └── report
│       ├── _c{d_
│       │   ├── base
│       │   ├── new
│       │   └── report
│       └── report
└── report

Fixes #189.

@coveralls
Copy link

coveralls commented Aug 17, 2018

Pull Request Test Coverage Report for Build 438

  • 0 of 22 (0.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 13.004%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/report.rs 0 1 0.0%
tests/criterion_tests.rs 0 2 0.0%
src/html/mod.rs 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
src/html/mod.rs 1 1.32%
src/plot/summary.rs 1 0.0%
Totals Coverage Status
Change from base Build 433: -0.008%
Covered Lines: 445
Relevant Lines: 3422

💛 - Coveralls

Fixes various issues related to directory name escaping.

Before:
```
├── g.r{ou
│   └── p
│       ├── report
│       └── t{e.s
│           └── t
│               └── report
├── g_r{ou_p
│   └── t{e_s_t
│       ├── _a_b_
│       │   ├── base
│       │   ├── new
│       │   └── report
│       └── _c{d_
│           ├── base
│           ├── new
│           └── report
└── report
```

After:
```
├── g_r{ou_p
│   ├── report
│   └── t{e_s_t
│       ├── _a_b_
│       │   ├── base
│       │   ├── new
│       │   └── report
│       ├── _c{d_
│       │   ├── base
│       │   ├── new
│       │   └── report
│       └── report
└── report
```

Fixes bheisler#189.
As far as I know, it's safe in every popular filesystem, and so doesn't have to be mangled.
@RReverser
Copy link
Contributor Author

@bheisler I've fixed Clippy warnings, builds should be passing now.

@RReverser
Copy link
Contributor Author

Seems to pass except for coverage changes (I'm not sure if these numbers are actually fair / important though).

@bheisler
Copy link
Owner

Hey, thanks for the pull request!

Yeah, don't worry about the coveralls numbers. They don't seem to reflect reality and I'm not really sure why. I should probably figure that out and fix it or drop the coveralls integration.

Anyway, I'll try to give this a proper code review soon.

@bheisler bheisler merged commit 3b72d04 into bheisler:master Aug 22, 2018
@bheisler
Copy link
Owner

Looks good to me. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants