-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix directory name escaping #191
Conversation
Pull Request Test Coverage Report for Build 438
💛 - Coveralls |
Fixes various issues related to directory name escaping. Before: ``` ├── g.r{ou │ └── p │ ├── report │ └── t{e.s │ └── t │ └── report ├── g_r{ou_p │ └── t{e_s_t │ ├── _a_b_ │ │ ├── base │ │ ├── new │ │ └── report │ └── _c{d_ │ ├── base │ ├── new │ └── report └── report ``` After: ``` ├── g_r{ou_p │ ├── report │ └── t{e_s_t │ ├── _a_b_ │ │ ├── base │ │ ├── new │ │ └── report │ ├── _c{d_ │ │ ├── base │ │ ├── new │ │ └── report │ └── report └── report ``` Fixes bheisler#189.
As far as I know, it's safe in every popular filesystem, and so doesn't have to be mangled.
@bheisler I've fixed Clippy warnings, builds should be passing now. |
Seems to pass except for coverage changes (I'm not sure if these numbers are actually fair / important though). |
Hey, thanks for the pull request! Yeah, don't worry about the coveralls numbers. They don't seem to reflect reality and I'm not really sure why. I should probably figure that out and fix it or drop the coveralls integration. Anyway, I'll try to give this a proper code review soon. |
Looks good to me. Thanks again! |
Fixes various issues related to directory name escaping.
Before:
After:
Fixes #189.