Skip to content

Commit 544c741

Browse files
committed
Remove dot from unsafe directory chars
As far as I know, it's safe in every popular filesystem, and so doesn't have to be mangled.
1 parent b4ccdff commit 544c741

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/report.rs

-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ impl BenchmarkId {
7575
.replace("\"", "_")
7676
.replace("/", "_")
7777
.replace("\\", "_")
78-
.replace(".", "_")
7978
.replace("*", "_")
8079
}
8180

tests/criterion_tests.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -407,15 +407,15 @@ fn test_output_files() {
407407
"test_output",
408408
Benchmark::new("output_1", |b| b.iter(|| 10))
409409
.with_function("output_2", |b| b.iter(|| 20))
410-
.with_function("output_\\/.*\"?", |b| b.iter(|| 30)),
410+
.with_function("output_\\/*\"?", |b| b.iter(|| 30)),
411411
);
412412
}
413413

414414
// For each benchmark, assert that the expected files are present.
415415
for x in 0..3 {
416416
let dir = if x == 2 {
417417
// Check that certain special characters are replaced with underscores
418-
tempdir.path().join(format!("test_output/output_______"))
418+
tempdir.path().join(format!("test_output/output______"))
419419
} else {
420420
tempdir.path().join(format!("test_output/output_{}", x + 1))
421421
};

0 commit comments

Comments
 (0)