Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target directory names for bench_function_over_inputs with strings #142

Closed
robinst opened this issue Apr 25, 2018 · 2 comments
Closed

Target directory names for bench_function_over_inputs with strings #142

robinst opened this issue Apr 25, 2018 · 2 comments
Milestone

Comments

@robinst
Copy link

robinst commented Apr 25, 2018

Hey! First off, thanks for this great tool! I have one minor issue, here's how to reproduce:

  1. Use bench_function_over_inputs and use strings for the input such as "foo/bar"
  2. Run the benchmark
  3. Look at the file names in the target directory

Expected: Not sure what :).
Actual: The files look like this:

  • target/criterion/fun/
    • "foo/
      • bar"/

While it makes sense, it's kind of unexpected and I wonder if it might be a good idea to replace special characters such as / and " before using them in file names. What do you think?

(This came up here and I have a minimal repo to reproduce it here.)

robinst added a commit to trishume/syntect that referenced this issue Apr 25, 2018
So that the file paths in target are a bit less weird, see
bheisler/criterion.rs#142.
@trishume
Copy link

It's not just that the directory structure is weird and unexpected, but for me it also breaks many of the figures and links in the HTML reports because it can't find things at the weird paths.

@bheisler
Copy link
Owner

Thanks for trying Criterion.rs! Thanks for the bug report.

I figured that would cause trouble sooner or later. I'll try to fix this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants