You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! First off, thanks for this great tool! I have one minor issue, here's how to reproduce:
Use bench_function_over_inputs and use strings for the input such as "foo/bar"
Run the benchmark
Look at the file names in the target directory
Expected: Not sure what :).
Actual: The files look like this:
target/criterion/fun/
"foo/
bar"/
While it makes sense, it's kind of unexpected and I wonder if it might be a good idea to replace special characters such as / and " before using them in file names. What do you think?
(This came up here and I have a minimal repo to reproduce it here.)
The text was updated successfully, but these errors were encountered:
robinst
added a commit
to trishume/syntect
that referenced
this issue
Apr 25, 2018
It's not just that the directory structure is weird and unexpected, but for me it also breaks many of the figures and links in the HTML reports because it can't find things at the weird paths.
Hey! First off, thanks for this great tool! I have one minor issue, here's how to reproduce:
bench_function_over_inputs
and use strings for the input such as"foo/bar"
target
directoryExpected: Not sure what :).
Actual: The files look like this:
target/criterion/fun/
"foo/
bar"/
While it makes sense, it's kind of unexpected and I wonder if it might be a good idea to replace special characters such as
/
and"
before using them in file names. What do you think?(This came up here and I have a minimal repo to reproduce it here.)
The text was updated successfully, but these errors were encountered: