Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No such file or directory" when running parts of benchmark #182

Closed
robinst opened this issue Jul 27, 2018 · 5 comments
Closed

"No such file or directory" when running parts of benchmark #182

robinst opened this issue Jul 27, 2018 · 5 comments
Milestone

Comments

@robinst
Copy link

robinst commented Jul 27, 2018

With criterion v0.2.4 and a clean target directory, when I run the following in the syntect repo:

cargo bench -- parse

There are some errors in the output:

     Running target/release/deps/highlighting-7594dd596dc32340
highlight/"parser.rs"   time:   [359.99 ms 361.81 ms 365.00 ms]
08:52:12 [ERROR] error: Failed to access file "target/criterion/highlight/\"scope.rs\"/new/sample.json": No such file or directory (os error 2)
08:52:12 [ERROR] caused by: Failed to access file "target/criterion/highlight/\"scope.rs\"/new/sample.json": No such file or directory (os error 2)
08:52:12 [ERROR] caused by: No such file or directory (os error 2)

The errors seem to be coming from files that were filtered out (because I only ran benchmarks with "parse" in the name).

Also, I thought those kind of names would no longer be used with #142?

(Didn't have the time to create a minimal reproducible example yet, but if it's not clear what the problem is I can do that.)

@bheisler
Copy link
Owner

Hey, thanks for trying Criterion.rs, and thanks for the bug report!

I think I'll have to investigate this one some more before I can say what's happening for sure. I thought the folder names were fixed now as well. I suppose it's always possible I missed something.

@bheisler bheisler added this to the Version 0.2.5 milestone Jul 29, 2018
@robinst
Copy link
Author

robinst commented Jul 30, 2018

You should be able to reproduce the problem by cloning this repo: https://github.com/robinst/criterion-example-string-inputs

And then run:

cargo bench -- foo

@bheisler
Copy link
Owner

bheisler commented Aug 4, 2018

This should be fixed in the next version. It runs your test case without issue, at least. Thanks again for the bug report!

@bheisler bheisler closed this as completed Aug 4, 2018
@robinst
Copy link
Author

robinst commented Aug 8, 2018

Thank you!

@RReverser
Copy link
Contributor

I'm having a similar issue, but with "File name too long" instead (I'm using parametrised benchmark and value debug representation apparently exceeds the OS limits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants