GSP-111: Add System Metadata In Storage Metadata #111
Conversation
JinnyYi
changed the title
| For service metadata, we will introduce `Strong Typed Service Metadata` like `ObjectMetadata`. We will generate following struct for specific service according to service pairs: | ||
|
|
||
| ```go | ||
| type ServiceMetadata struct { | ||
| <service meta> <type> | ||
| ... | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Do I understand correctly?
- In
go-storage/types, there are typeObject(has fieldserviceMetadata interface{}), andStorageMeta - In
go-service-*typeObjectMetadatais used to setserviceMetadata, and has getterGetObjectMetadata
Now, this proposal intends to also add the field serviceMetadata interface{} to StorageMeta. Should the go-service-* type be called StorageMetadata?
And I'm wondering why type Object and StorageMeta are at the same level 🤔
There was a problem hiding this comment.
Do we need to rename go-service-*.ObjectMetadata into something like go-service-*.ServiceObjectMetadata to avoid confusion? (and correspondingly, ServiceStorageMeta in this proposal.)
There was a problem hiding this comment.
The root cause is Object is a struct but Storager is an interface.
If Storage is a struct that exposed to the user, we can set serviceMetadata in Storage struct just like we do on Object.
Well, StorageMeta and StorageMetadata do look wired to me too. Do you have a better idea/name for that?
There was a problem hiding this comment.
I think the most wired one is that both go-storage.Object and go-storage.StorageMeta will have field serviceMetadata,
but go-service-*.ServiceMetadata will be the one that belongs to StorageMeta. This seems to be rather confusing
There was a problem hiding this comment.
I got it.
The problem is introduced by simplify
Service Level/Specified Object MetadatatoserviceMetadatainObjectService Level/Specified Storage MetadatatoserviceMetadatainStorageMeta
But I don't have better ideas about the name.
There was a problem hiding this comment.
What about ServiceObjectMetadata and ServiceStorageMetadata?
Naming is so difficult!
There was a problem hiding this comment.
Maybe we can find the opposite word of global to represent all those situations? So we can:
- Distinguish
Service PairandService's Pair - Distinguish
Service MetadataandService's Metadata - ...
And our API will turn into:
func GetObjectXxxxMetadata(o* Object) ObjectXxxxMetadata
func GetStorageXxxxMetadata(s *StorageMeta) StorageXxxxMetadataThere was a problem hiding this comment.
- Distinguish
Service PairandService's Pair- Distinguish
Service MetadataandService's Metadata
Do I understand correctly?
Service Paircould be all the pairs in the current service.Service's Pairjust means pairs related to the service implementations.Service Metadataincludesobject service metadataandstorage service metadata.Service's Metadatacould corresponds toStorageMetahere.
|
ping @JinnyYi , Let's use |
JinnyYi
changed the title
fix: #84