Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Re-enable test_property_type_registration() #4419

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Re-enable test_property_type_registration() #4419

wants to merge 1 commit into from

Conversation

alice-i-cecile
Copy link
Member

Objective

  • This test was mysteriously commented out

Solution

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Reflection Runtime information about types labels Apr 4, 2022
MrGVSV
MrGVSV approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I wonder why there's no non-generic test 🤔 (probably just too trivial?)

@alice-i-cecile
Copy link
Member Author

probably just too trivial?

Yeah, that's my guess. I'm not sure it would catch any interesting edge cases.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 4, 2022
@alice-i-cecile
Copy link
Member Author

Apparently this test has always been disabled, starting from the first commit on this file: 72b2fc9

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Apr 4, 2022
@cart
Copy link
Member

cart commented Apr 5, 2022

Hmm yeah I dont remember why this was commented out :)

@cart
Copy link
Member

cart commented Apr 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2022
@alice-i-cecile
Re-enable test_property_type_registration() (#4419)
dbb2fcb 
# Objective

- This test was mysteriously commented out

## Solution

- Re-enable it
- Also done in #4299, but this is better as its own PR.
@bors
Copy link
Contributor

bors bot commented Apr 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Re-enable test_property_type_registration() [Merged by Bors] - Re-enable test_property_type_registration() Apr 5, 2022
@bors bors bot closed this Apr 5, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@alice-i-cecile @aevyrie
Re-enable test_property_type_registration() (bevyengine#4419)
01821b4 
# Objective

- This test was mysteriously commented out

## Solution

- Re-enable it
- Also done in bevyengine#4299, but this is better as its own PR.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @ItsDoot
Re-enable test_property_type_registration() (bevyengine#4419)
6e4a325 
# Objective

- This test was mysteriously commented out

## Solution

- Re-enable it
- Also done in bevyengine#4299, but this is better as its own PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alice-i-cecile @cart @mockersf @MrGVSV