Skip to content

Commit

Permalink
Re-enable test_property_type_registration() (bevyengine#4419)
Browse files Browse the repository at this point in the history
# Objective

- This test was mysteriously commented out

## Solution

- Re-enable it
- Also done in bevyengine#4299, but this is better as its own PR.
  • Loading branch information
alice-i-cecile authored and ItsDoot committed Feb 1, 2023
1 parent e23e294 commit 6e4a325
Showing 1 changed file with 33 additions and 33 deletions.
66 changes: 33 additions & 33 deletions crates/bevy_reflect/src/type_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ impl<T: for<'a> Deserialize<'a> + Reflect> FromType<T> for ReflectDeserialize {
#[cfg(test)]
mod test {
use crate::TypeRegistration;
use bevy_utils::HashMap;

#[test]
fn test_get_short_name() {
Expand Down Expand Up @@ -390,37 +391,36 @@ mod test {
);
}

// TODO: re-enable
// #[test]
// fn test_property_type_registration() {
// assert_eq!(
// TypeRegistration::of::<Option<f64>>().short_name,
// "Option<f64>"
// );
// assert_eq!(
// TypeRegistration::of::<HashMap<u32, String>>().short_name,
// "HashMap<u32, String>"
// );
// assert_eq!(
// TypeRegistration::of::<Option<HashMap<u32, String>>>().short_name,
// "Option<HashMap<u32, String>>"
// );
// assert_eq!(
// TypeRegistration::of::<Option<HashMap<u32, Option<String>>>>().short_name,
// "Option<HashMap<u32, Option<String>>>"
// );
// assert_eq!(
// TypeRegistration::of::<Option<HashMap<String, Option<String>>>>().short_name,
// "Option<HashMap<String, Option<String>>>"
// );
// assert_eq!(
// TypeRegistration::of::<Option<HashMap<Option<String>, Option<String>>>>().short_name,
// "Option<HashMap<Option<String>, Option<String>>>"
// );
// assert_eq!(
// TypeRegistration::of::<Option<HashMap<Option<String>, (String, Option<String>)>>>()
// .short_name,
// "Option<HashMap<Option<String>, (String, Option<String>)>>"
// );
// }
#[test]
fn test_property_type_registration() {
assert_eq!(
TypeRegistration::of::<Option<f64>>().short_name,
"Option<f64>"
);
assert_eq!(
TypeRegistration::of::<HashMap<u32, String>>().short_name,
"HashMap<u32, String>"
);
assert_eq!(
TypeRegistration::of::<Option<HashMap<u32, String>>>().short_name,
"Option<HashMap<u32, String>>"
);
assert_eq!(
TypeRegistration::of::<Option<HashMap<u32, Option<String>>>>().short_name,
"Option<HashMap<u32, Option<String>>>"
);
assert_eq!(
TypeRegistration::of::<Option<HashMap<String, Option<String>>>>().short_name,
"Option<HashMap<String, Option<String>>>"
);
assert_eq!(
TypeRegistration::of::<Option<HashMap<Option<String>, Option<String>>>>().short_name,
"Option<HashMap<Option<String>, Option<String>>>"
);
assert_eq!(
TypeRegistration::of::<Option<HashMap<Option<String>, (String, Option<String>)>>>()
.short_name,
"Option<HashMap<Option<String>, (String, Option<String>)>>"
);
}
}

0 comments on commit 6e4a325

Please sign in to comment.