Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a basic version of grouping binary expressions working. #84

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

belav
Copy link
Owner

@belav belav commented Apr 12, 2021

Playing around with an idea for how to start pulling apart the partial class

Playing around with an idea for how to start pulling apart the partial class
@belav
Copy link
Owner Author

belav commented Apr 12, 2021

Some of this is a little ugly with how SyntaxNodes and Printer interact, but the idea is that it is just temporary and provides a way to start moving away from the partial class without having to do it all at once.
I'm also not sure about the naming and it's currently a little inconsistent.
BinaryExpression.Print(node)
vs
SyntaxNodes.Print(node)
SyntaxTokens.Print(token)
Maybe all the class names should be pluralized? It sounds a little weird, but we can't name it SyntaxNode and SyntaxToken without colliding with existing names.
Or we can just come up with different names for SyntaxNodes and SyntaxTokens. Node.Print, Token.Print

@belav belav mentioned this pull request Apr 12, 2021
@belav belav merged commit 86a620b into master Apr 12, 2021
@belav belav deleted the binary-grouping branch April 12, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant