BinaryExpression Grouping

[belav]

Take this example

var longNameForcesLineBreakYeahLongName =
    someValue == someOtherValue && x == 7;

The && is the root BinaryExpression, which is a LogicalAnd
The left and right of it are EqualsExpression.
CSharpier should group the LogicalAnd, but if it groups every binary Expression than the following doesn't format correctly.

if (
    longStatementName
    && longerStatementName
    && evenLongerStatementName
    && superLongStatementName
) { }

Which is basically a tree of BinaryExpressions where the Left is LogicalAnd BinaryExpression and the Right is IdentifierName.
This may require flattening out BinaryExpressions and conditionally grouping them based on what operation they are performing.

See prettier/src/language-js/print/binaryish.js for all the logic that goes into making this work for js

[belav]

This is also related

    return value == null
    || string.IsNullOrEmpty(value.Trim());
// should be
    return value == null
        || string.IsNullOrEmpty(value.Trim());

[belav]

This was partially addressed in #84 but requires a lot more work

[belav]

this looks weird

        if (
            trivia.Kind() == SyntaxKind.SingleLineCommentTrivia
            || trivia.Kind()
            == SyntaxKind.SingleLineDocumentationCommentTrivia1111111
        ) { }

[belav]

See also

        protected override bool IsBinaryLike(ExpressionSyntax node) =>
            node is BinaryExpressionSyntax
            || node
                is IsPatternExpressionSyntax isPattern
            && isPattern.Pattern is ConstantPatternSyntax;

[dishuk13]

Related

while (
  // stop if we have reached the end of the token being read
  initialDepth - 1 <
    reader.Depth - (JsonTokenUtils.IsEndToken(reader.TokenType) ? 1 : 0) &&
  writeChildren &&
  reader.Read()
);

https://github.com/belav/Newtonsoft.Json/blob/397e45649325788b5ea299be3ca5303b86eeaf9b/Src/Newtonsoft.Json/JsonWriter.cs#L773

[respel]

See also

if (
    query
    && (currentChar == '='
    || currentChar == '<'
    || currentChar == '!'
    || currentChar == '>'
    || currentChar == '|'
    || currentChar == '&')
) {
    ended = true;
}

The current alignment leads you to believe that the && and || operators are chained but they aren't really. We should do some kind of nesting here.

[belav]

Make sure to handle the test case in SwitchExpression that isn't indenting.