Use common logic for printing rhs of assignment expressions #324
Conversation
| @@ -62,8 +62,7 @@ class ClassName | |||
| var collectionInitializerExpressions = new SomeObject | |||
| { | |||
| ThisIsACollection = { one, two }, | |||
| ThisIsAlsoACollection = | |||
| { | |||
| ThisIsAlsoACollection = { | |||
There was a problem hiding this comment.
I think we want to keep the old formatting on this, but your change does get this consistent with arrayInitializerWithoutSize above it. It could also be a new issue.
| node.Right is InitializerExpressionSyntax ? Doc.Null : " ", | ||
| Node.Print(node.Right) | ||
| ) | ||
| RightHandSide.Print(node.Right) |
There was a problem hiding this comment.
👍 for reusing the code from VariableDeclaration in here
| or LambdaExpressionSyntax | ||
| or AwaitExpressionSyntax | ||
| or WithExpressionSyntax | ||
| ? FormatMode.NoIndent |
There was a problem hiding this comment.
This looks like a nested ternary if on type matches. Usually, a switch statement looks better.
Not sure how good it will look with a dozen ors. But if it doesn't look good you can probably split them into multiple arms of the switch.
|
|
||
| private static Doc IndentIfNeeded(ExpressionSyntax initializerValue, FormatMode formatMode) | ||
| { | ||
| if (formatMode is FormatMode.NoIndent) |
There was a problem hiding this comment.
I think this whole function could be replaced by an expression bodied method with a single switch statement. Up to you if you think this code looks better though.
| public static Doc Print(ExpressionSyntax node) | ||
| { | ||
| var groupId = Guid.NewGuid().ToString(); | ||
| return node switch |
There was a problem hiding this comment.
This gives us another good test case for #237.
Updates #37