FF6WC: Remove ArchplgoItem from shops #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The implementation of the AP version of FF6WC required that an item be sent for processing to work correctly. The original implementer chose to alter the RenameCard, an item which allows you to rename characters but has no other inherent gameplay functionality, to be the ArchplgoItem which is what is used to pass rewards to the FF6WC player and is collected by them to send to other players.
When this item that had been re-purposed from the RenameCard showed up in shops, this was very confusing for newer players as they may have thought that they needed to purchase the item to complete a check, however, that is not the case since it's not actually a check, just a repurposed item. Removing them from shops avoids any confusion and does not detract from any gameplay.
How was this tested?
Unfortunately, AP's spoiler log file at Generate time does NOT include all of the log functions for the FF6WC game, and it appears at Launcher time, this .txt file is never generated, so I had to put this code into the WorldsCollide base and test using this spoiler log. I updated the flagstring to include the -sl flag to print a spoiler log when seeds were generated. I verified that the RenameCard does NOT appear in any shops, which would be the ArchplgoItem in the other version of the code.
If this makes graphical changes, please attach screenshots.