Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not Merge] Cookie translation updates #9022

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

aeroplanejane
Copy link

Resolves #8914

Overall change:
Changing international canonical cookie banner text to use UK wording

Code changes:

-updates canonical international cookie banner text across service configs
-copied from uk canonical text in config


  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@aeroplanejane aeroplanejane added the ws-articles Tasks for the WS Articles Team label Mar 31, 2021
@andrewscfc
Copy link
Contributor

Looks like the E2E tests still need updating @aeroplanejane , maybe one @LilyL0u can help with?

@aeroplanejane aeroplanejane changed the title [Do Not Merge] Cookie translation updates Cookie translation updates Mar 31, 2021
@aeroplanejane aeroplanejane changed the title Cookie translation updates [Do not Merge] Cookie translation updates Mar 31, 2021
@aeroplanejane
Copy link
Author

aeroplanejane commented Mar 31, 2021

Waiting for word from GNL in the simorgh-ads channel that the CMP changes have gone live before merging.

@andrewscfc andrewscfc merged commit fbe9de5 into latest Mar 31, 2021
@andrewscfc andrewscfc deleted the cookie-translation-updates branch March 31, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants