Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BADGERS-177 Failover with MPD times in MSE strategy #302

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

eirikbjornr
Copy link
Contributor

@eirikbjornr eirikbjornr commented Jun 22, 2023

📺 What

Pass current MPD time to Dash.js to restart playback with a new source at the same point in time on CDN failover.

🛠 How

  • Move buildSourceAnchor to a new file. Make it handle MPD time and video time.
  • Modify MSEStrategy to pass failover time as an MPD time instead of a video time.

Note:

This is a PR to merge into branch badgers-177, not master. I've chunked the ticket into two PRs to make reviews easier.

@eirikbjornr eirikbjornr added bug fix Fix a bug semver patch This PR is a semver patch release labels Jun 22, 2023
@eirikbjornr eirikbjornr self-assigned this Jun 22, 2023
@eirikbjornr eirikbjornr requested a review from a team as a code owner June 22, 2023 14:28
@eirikbjornr eirikbjornr changed the title BADGERS-177 Failover with MPT times in MSE strategy BADGERS-177 Failover with MPD times in MSE strategy Jun 22, 2023
@ShiningTrapez ShiningTrapez merged commit f08062a into badgers-177 Jun 26, 2023
@ShiningTrapez ShiningTrapez deleted the badgers-177-simulcast branch June 26, 2023 09:13
@eirikbjornr eirikbjornr mentioned this pull request Jul 6, 2023
eirikbjornr added a commit that referenced this pull request Jul 6, 2023
* BADGERS-177 Use `UTCTiming` for wall-clock time (#299)

* wip: commit to test upgrading jest

* chore: upgrade jest to v29

* test: missing timing resource

* fix: hls tests

* feat: promisify manifest loader

* chore: remove redundant placeholders

* test: make MediaSources tests handle promisified manifest loader

* feat: return promise from loadManifest

* fix: triple load bug

* fix: don't provide wallclock time on failover or refresh

* feat: log error in dev client

* feat: let DebugTool take error objects

* feat: log manifest load failure

* chore: remove unused vars

* docs: reference source

* fix: handle load failures with no cause given

* feat: add warn method and fix error method

* chore: add deprecation note to server date

* doc: deprecate server date

* fix: move jsdom to dev dependencies

* refactor: async/await tests

* docs: expand documentation

* fix: boolean logic

* fix: export mutable

* fix: use absolute time to seek sliding window in a failover

* chore: remove comment

* BADGERS-177 Failover with MPD times in MSE strategy (#302)

* style: make magic numbers in tests variables

* refactor: optimise manifest regex

* test: url with query param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug semver patch This PR is a semver patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants